201911 fixes #4716 show ipv6 interface neighbor_ip N/A issue #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-rj
changed the title
|
Is this issue happening in master as well? If not, what is the fix in master? Ideally we want to cherry-pick bug fix from master to 201911. |
Hi, this issue should exist in master as well, I will try to compile bsp module based on master's kernel as soon as possible. The key point to reproduce is that the port should 'UP' and has a local linked address, then the neighbor_ip will be written by 'N/A' . |
|
Ok, then you should be raising the PR to master and can mark for cherry-pick to 201911. |
This was referenced Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
When exec 'show ipv6 interfaces', the neighbor_ip will always be 'N/A' which will confuse the consumers. After checking we found that this is a show issue. As we know, there will be one local linked IPV6 address for every valid interface. In show/main.py, the interface's ipv6 neighbor ip will always be written by this local linked IPV6's neighbor_ip address which is 'N/A'. And i think this part code of 'show ipv6 interface' was copied from 'show ip interface' before, right? Yea, some change is necessary!
- What I did
This is bug fixing.
- How I did it
Code change.
- How to verify it
upgrate config_db.config attached in sonic-net/sonic-buildimage#4716 and show ipv6 interfaces