-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VXLAN config and show utilities #870
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
42b055d
Changes to support EVPN VXLAN.
srj102 2c609e2
Changed the same for REMOTE_VNI Table.
srj102 7e036df
Fixed LGTM Warnings
srj102 be0278f
Added VRF VNI Map CLI.
tapashdas fa13994
LTGM Warning Fix.
tapashdas 68521b6
NeighSuppression Changes
kananthak 39561f0
1. Updated EVPN DB names.
srj102 c410175
NeighSuppressConfigCliFix
kananthak 818009b
Added UT Fix for VRF VNI MAP CLI.
tapashdas d507145
Incorporated Review comment regarding hardcoding of values.
srj102 432e7c1
Review comments incorporated.
srj102 7221a17
Added tests for VXLAN CLI
srj102 c696f69
Changes to test script to add newline in output.
srj102 403d07e
test scripts for vxlan config and show utilities added.
srj102 b95be1b
Removing ARP/ND suppression CLIs on behalf of karthikeyan
srj102 86779ec
Merge branch 'master' into evpn_vxlan
srj102 95dc9b9
Update main.py
srj102 d9e9df6
Renamed show vxlan tunnel to show vxlan remotevtep.
srj102 24958ff
Updated review comments.
tapashdas 074ca0d
Update main.py
tapashdas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,273 @@ | ||
import click | ||
import utilities_common.cli as clicommon | ||
|
||
# | ||
# 'vxlan' group ('config vxlan ...') | ||
# | ||
@click.group() | ||
def vxlan(): | ||
pass | ||
|
||
@vxlan.command('add') | ||
@click.argument('vxlan_name', metavar='<vxlan_name>', required=True) | ||
@click.argument('src_ip', metavar='<src_ip>', required=True) | ||
@clicommon.pass_db | ||
def add_vxlan(db, vxlan_name, src_ip): | ||
"""Add VXLAN""" | ||
ctx = click.get_current_context() | ||
|
||
if not clicommon.is_ipaddress(src_ip): | ||
ctx.fail("{} invalid src ip address".format(src_ip)) | ||
|
||
vxlan_keys = db.cfgdb.get_keys('VXLAN_TUNNEL') | ||
if not vxlan_keys: | ||
vxlan_count = 0 | ||
else: | ||
vxlan_count = len(vxlan_keys) | ||
|
||
if(vxlan_count > 0): | ||
ctx.fail("VTEP already configured.") | ||
|
||
fvs = {'src_ip': src_ip} | ||
db.cfgdb.set_entry('VXLAN_TUNNEL', vxlan_name, fvs) | ||
|
||
@vxlan.command('del') | ||
@click.argument('vxlan_name', metavar='<vxlan_name>', required=True) | ||
@clicommon.pass_db | ||
def del_vxlan(db, vxlan_name): | ||
"""Del VXLAN""" | ||
ctx = click.get_current_context() | ||
|
||
vxlan_keys = db.cfgdb.get_keys('VXLAN_EVPN_NVO') | ||
if not vxlan_keys: | ||
vxlan_count = 0 | ||
else: | ||
vxlan_count = len(vxlan_keys) | ||
|
||
if(vxlan_count > 0): | ||
ctx.fail("Please delete the EVPN NVO configuration.") | ||
|
||
vxlan_keys = db.cfgdb.get_keys('CONFIG_DB', "VXLAN_TUNNEL_MAP|*") | ||
if not vxlan_keys: | ||
vxlan_count = 0 | ||
else: | ||
vxlan_count = len(vxlan_keys) | ||
|
||
if(vxlan_count > 0): | ||
ctx.fail("Please delete all VLAN VNI mappings.") | ||
|
||
db.cfgdb.set_entry('VXLAN_TUNNEL', vxlan_name, None) | ||
|
||
@vxlan.group('evpn_nvo') | ||
def vxlan_evpn_nvo(): | ||
pass | ||
|
||
@vxlan_evpn_nvo.command('add') | ||
@click.argument('nvo_name', metavar='<nvo_name>', required=True) | ||
@click.argument('vxlan_name', metavar='<vxlan_name>', required=True) | ||
@clicommon.pass_db | ||
def add_vxlan_evpn_nvo(db, nvo_name, vxlan_name): | ||
"""Add NVO""" | ||
ctx = click.get_current_context() | ||
vxlan_keys = db.cfgdb.get_keys('CONFIG_DB', "VXLAN_EVPN_NVO|*") | ||
if not vxlan_keys: | ||
vxlan_count = 0 | ||
else: | ||
vxlan_count = len(vxlan_keys) | ||
|
||
if(vxlan_count > 0): | ||
ctx.fail("EVPN NVO already configured") | ||
|
||
if len(db.cfgdb.get_entry('VXLAN_TUNNEL', vxlan_name)) == 0: | ||
ctx.fail("VTEP {} not configured".format(vxlan_name)) | ||
|
||
fvs = {'source_vtep': vxlan_name} | ||
db.cfgdb.set_entry('VXLAN_EVPN_NVO', nvo_name, fvs) | ||
|
||
@vxlan_evpn_nvo.command('del') | ||
@click.argument('nvo_name', metavar='<nvo_name>', required=True) | ||
@clicommon.pass_db | ||
def del_vxlan_evpn_nvo(db, nvo_name): | ||
"""Del NVO""" | ||
ctx = click.get_current_context() | ||
vxlan_keys = db.cfgdb.get_keys('VXLAN_TUNNEL_MAP') | ||
if not vxlan_keys: | ||
vxlan_count = 0 | ||
else: | ||
vxlan_count = len(vxlan_keys) | ||
|
||
if(vxlan_count > 0): | ||
ctx.fail("Please delete all VLAN VNI mappings.") | ||
db.cfgdb.set_entry('VXLAN_EVPN_NVO', nvo_name, None) | ||
|
||
@vxlan.group('map') | ||
def vxlan_map(): | ||
pass | ||
|
||
@vxlan_map.command('add') | ||
@click.argument('vxlan_name', metavar='<vxlan_name>', required=True) | ||
@click.argument('vlan', metavar='<vlan_id>', required=True) | ||
@click.argument('vni', metavar='<vni>', required=True) | ||
@clicommon.pass_db | ||
def add_vxlan_map(db, vxlan_name, vlan, vni): | ||
"""Add VLAN-VNI map entry""" | ||
ctx = click.get_current_context() | ||
|
||
if not vlan.isdigit(): | ||
ctx.fail("Invalid vlan {}. Only valid vlan is accepted".format(vni)) | ||
if clicommon.is_vlanid_in_range(int(vlan)) is False: | ||
ctx.fail(" Invalid Vlan Id , Valid Range : 1 to 4094 ") | ||
if not vni.isdigit(): | ||
ctx.fail("Invalid VNI {}. Only valid VNI is accepted".format(vni)) | ||
if clicommon.vni_id_is_valid(int(vni)) is False: | ||
ctx.fail("Invalid VNI {}. Valid range [1 to 16777215].".format(vni)) | ||
|
||
vlan_name = "Vlan" + vlan | ||
|
||
if len(db.cfgdb.get_entry('VXLAN_TUNNEL', vxlan_name)) == 0: | ||
ctx.fail("VTEP {} not configured".format(vxlan_name)) | ||
|
||
if len(db.cfgdb.get_entry('VLAN', vlan_name)) == 0: | ||
ctx.fail("{} not configured".format(vlan_name)) | ||
|
||
vxlan_table = db.cfgdb.get_table('VXLAN_TUNNEL_MAP') | ||
vxlan_keys = vxlan_table.keys() | ||
if vxlan_keys is not None: | ||
for key in vxlan_keys: | ||
if (vxlan_table[key]['vlan'] == vlan_name): | ||
ctx.fail(" Vlan Id already mapped ") | ||
if (vxlan_table[key]['vni'] == vni): | ||
ctx.fail(" VNI Id already mapped ") | ||
|
||
fvs = {'vni': vni, | ||
'vlan' : vlan_name} | ||
mapname = vxlan_name + '|' + 'map_' + vni + '_' + vlan_name | ||
db.cfgdb.set_entry('VXLAN_TUNNEL_MAP', mapname, fvs) | ||
|
||
@vxlan_map.command('del') | ||
@click.argument('vxlan_name', metavar='<vxlan_name>', required=True) | ||
@click.argument('vlan', metavar='<vlan_id>', required=True) | ||
@click.argument('vni', metavar='<vni>', required=True) | ||
@clicommon.pass_db | ||
def del_vxlan_map(db, vxlan_name, vlan, vni): | ||
"""Del VLAN-VNI map entry""" | ||
ctx = click.get_current_context() | ||
|
||
if not vlan.isdigit(): | ||
ctx.fail("Invalid vlan {}. Only valid vlan is accepted".format(vni)) | ||
if clicommon.is_vlanid_in_range(int(vlan)) is False: | ||
ctx.fail(" Invalid Vlan Id , Valid Range : 1 to 4094 ") | ||
if not vni.isdigit(): | ||
ctx.fail("Invalid VNI {}. Only valid VNI is accepted".format(vni)) | ||
if clicommon.vni_id_is_valid(int(vni)) is False: | ||
ctx.fail("Invalid VNI {}. Valid range [1 to 16777215].".format(vni)) | ||
|
||
if len(db.cfgdb.get_entry('VXLAN_TUNNEL', vxlan_name)) == 0: | ||
ctx.fail("VTEP {} not configured".format(vxlan_name)) | ||
found = 0 | ||
vrf_table = db.cfgdb.get_table('VRF') | ||
vrf_keys = vrf_table.keys() | ||
if vrf_keys is not None: | ||
for vrf_key in vrf_keys: | ||
if ('vni' in vrf_table[vrf_key] and vrf_table[vrf_key]['vni'] == vni): | ||
found = 1 | ||
break | ||
|
||
if (found == 1): | ||
ctx.fail("VNI mapped to vrf {}, Please remove VRF VNI mapping".format(vrf_key)) | ||
|
||
mapname = vxlan_name + '|' + 'map_' + vni + '_' + vlan | ||
db.cfgdb.set_entry('VXLAN_TUNNEL_MAP', mapname, None) | ||
mapname = vxlan_name + '|' + 'map_' + vni + '_Vlan' + vlan | ||
db.cfgdb.set_entry('VXLAN_TUNNEL_MAP', mapname, None) | ||
|
||
@vxlan.group('map_range') | ||
def vxlan_map_range(): | ||
pass | ||
|
||
@vxlan_map_range.command('add') | ||
@click.argument('vxlan_name', metavar='<vxlan_name>', required=True) | ||
@click.argument('vlan_start', metavar='<vlan_start>', required=True, type=int) | ||
@click.argument('vlan_end', metavar='<vlan_end>', required=True, type=int) | ||
@click.argument('vni_start', metavar='<vni_start>', required=True, type=int) | ||
@clicommon.pass_db | ||
def add_vxlan_map_range(db, vxlan_name, vlan_start, vlan_end, vni_start): | ||
"""Add Range of vlan-vni mappings""" | ||
ctx = click.get_current_context() | ||
if clicommon.is_vlanid_in_range(vlan_start) is False: | ||
ctx.fail(" Invalid Vlan Id , Valid Range : 1 to 4094 ") | ||
if clicommon.is_vlanid_in_range(vlan_end) is False: | ||
ctx.fail(" Invalid Vlan Id , Valid Range : 1 to 4094 ") | ||
if (vlan_start > vlan_end): | ||
ctx.fail("vlan_end should be greater or equal to vlan_start") | ||
if clicommon.vni_id_is_valid(vni_start) is False: | ||
ctx.fail("Invalid VNI {}. Valid range [1 to 16777215].".format(vni_start)) | ||
if clicommon.vni_id_is_valid(vni_start+vlan_end-vlan_start) is False: | ||
ctx.fail("Invalid VNI End {}. Valid range [1 to 16777215].".format(vni_start)) | ||
|
||
if len(db.cfgdb.get_entry('VXLAN_TUNNEL', vxlan_name)) == 0: | ||
ctx.fail("VTEP {} not configured".format(vxlan_name)) | ||
vlan_end = vlan_end + 1 | ||
vxlan_table = db.cfgdb.get_table('VXLAN_TUNNEL_MAP') | ||
vxlan_keys = vxlan_table.keys() | ||
|
||
for vid in range (vlan_start, vlan_end): | ||
vlan_name = 'Vlan{}'.format(vid) | ||
vnid = vni_start+vid-vlan_start | ||
vni_name = '{}'.format(vnid) | ||
match_found = 'no' | ||
if len(db.cfgdb.get_entry('VLAN', vlan_name)) == 0: | ||
click.echo("{} not configured".format(vlan_name)) | ||
continue | ||
if vxlan_keys is not None: | ||
for key in vxlan_keys: | ||
if (vxlan_table[key]['vlan'] == vlan_name): | ||
print(vlan_name + " already mapped") | ||
match_found = 'yes' | ||
break | ||
if (vxlan_table[key]['vni'] == vni_name): | ||
print("VNI:" + vni_name + " already mapped ") | ||
match_found = 'yes' | ||
break | ||
if (match_found == 'yes'): | ||
continue | ||
fvs = {'vni': vni_name, | ||
'vlan' : vlan_name} | ||
mapname = vxlan_name + '|' + 'map_' + vni_name + '_' + vlan_name | ||
db.cfgdb.set_entry('VXLAN_TUNNEL_MAP', mapname, fvs) | ||
|
||
@vxlan_map_range.command('del') | ||
@click.argument('vxlan_name', metavar='<vxlan_name>', required=True) | ||
@click.argument('vlan_start', metavar='<vlan_start>', required=True, type=int) | ||
@click.argument('vlan_end', metavar='<vlan_end>', required=True, type=int) | ||
@click.argument('vni_start', metavar='<vni_start>', required=True, type=int) | ||
@clicommon.pass_db | ||
def del_vxlan_map_range(db, vxlan_name, vlan_start, vlan_end, vni_start): | ||
"""Del Range of vlan-vni mappings""" | ||
ctx = click.get_current_context() | ||
if clicommon.is_vlanid_in_range(vlan_start) is False: | ||
ctx.fail(" Invalid Vlan Id , Valid Range : 1 to 4094 ") | ||
if clicommon.is_vlanid_in_range(vlan_end) is False: | ||
ctx.fail(" Invalid Vlan Id , Valid Range : 1 to 4094 ") | ||
if (vlan_start > vlan_end): | ||
ctx.fail("vlan_end should be greater or equal to vlan_start") | ||
if clicommon.vni_id_is_valid(vni_start) is False: | ||
ctx.fail("Invalid VNI {}. Valid range [1 to 16777215].".format(vni_start)) | ||
if clicommon.vni_id_is_valid(vni_start+vlan_end-vlan_start) is False: | ||
ctx.fail("Invalid VNI End {}. Valid range [1 to 16777215].".format(vni_start)) | ||
|
||
if len(db.cfgdb.get_entry('VXLAN_TUNNEL', vxlan_name)) == 0: | ||
ctx.fail("VTEP {} not configured".format(vxlan_name)) | ||
|
||
vlan_end = vlan_end + 1 | ||
for vid in range (vlan_start, vlan_end): | ||
vlan_name = 'Vlan{}'.format(vid) | ||
vnid = vni_start+vid-vlan_start | ||
vni_name = '{}'.format(vnid) | ||
if clicommon.is_vni_vrf_mapped(db, vni_name) is False: | ||
print("Skipping Vlan {} VNI {} mapped delete. ".format(vlan_name, vni_name)) | ||
continue | ||
|
||
mapname = vxlan_name + '|' + 'map_' + vni_name + '_' + vlan_name | ||
db.cfgdb.set_entry('VXLAN_TUNNEL_MAP', mapname, None) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1522,6 +1522,5 @@ def ztp(status, verbose): | |
cmd = cmd + " --verbose" | ||
run_command(cmd, display_cmd=verbose) | ||
|
||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change doesn't look obligatory. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will handle this in the next PR. |
||
if __name__ == '__main__': | ||
cli() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you have some test coverage for this case as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok will do.