[fast/warm-reboot] Improve retry mechanism to check if SAI_OBJECT_TYPE_ACL_ENTRY entries are in redis #3548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…E_ACL_ENTRY entries are in redis Signed-off-by: Andriy Yurkiv <[email protected]>
Signed-off-by: Andriy Yurkiv <[email protected]>
ryanzhu706
approved these changes
Sep 23, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Sep 30, 2024
…PE_ACL_ENTRY entries are in redis (sonic-net#3548) * [fast/warm-reboot] Improve retry mechanism to check if SAI_OBJECT_TYPE_ACL_ENTRY entries are in redis Signed-off-by: Andriy Yurkiv <[email protected]> * Change log severity Signed-off-by: Andriy Yurkiv <[email protected]> --------- Signed-off-by: Andriy Yurkiv <[email protected]>
|
Cherry-pick PR to 202405: #3560 |
mssonicbld
pushed a commit
that referenced
this pull request
Sep 30, 2024
…PE_ACL_ENTRY entries are in redis (#3548) * [fast/warm-reboot] Improve retry mechanism to check if SAI_OBJECT_TYPE_ACL_ENTRY entries are in redis Signed-off-by: Andriy Yurkiv <[email protected]> * Change log severity Signed-off-by: Andriy Yurkiv <[email protected]> --------- Signed-off-by: Andriy Yurkiv <[email protected]>
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Sometimes during
/usr/local/bin/neighbor_advertiserscript execution, ACL entries are added to redis database with delay.So during execution of function
check_mirror_session_acls()script can't find ACL entries.Retry mechanism was added for this check in #3333
But the script will return error and exit with failure after first try.
Need to improve this algorithm.
How I did it
add sleep 0.1 and 'continue' instead of 'exit'
How to verify it
run wr_arp test
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)