Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix show techsupport date issue #3437

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

ganglyu
Copy link
Contributor

@ganglyu ganglyu commented Jul 20, 2024

What I did

Show techsupport is designed to collect logs and core files since given date.
I find that some core files are missing when given date is relative, for example "5 minutes ago".
Microsoft ADO: 28737486

How I did it

Create the reference file at the start of the script, and don't update it in find_files.

How to verify it

Run end to end test: show_techsupport/test_auto_techsupport.py

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@ganglyu ganglyu requested a review from qiluo-msft July 22, 2024 00:22
Copy link
Contributor

@wen587 wen587 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ltgm

@ganglyu ganglyu merged commit f196622 into sonic-net:master Jul 23, 2024
7 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-utilities that referenced this pull request Jul 23, 2024
What I did
Show techsupport is designed to collect logs and core files since given date.
I find that some core files are missing when given date is relative, for example "5 minutes ago".
Microsoft ADO: 28737486

How I did it
Create the reference file at the start of the script, and don't update it in find_files.

How to verify it
Run end to end test: show_techsupport/test_auto_techsupport.py
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #3440

mssonicbld pushed a commit to mssonicbld/sonic-utilities that referenced this pull request Jul 23, 2024
What I did
Show techsupport is designed to collect logs and core files since given date.
I find that some core files are missing when given date is relative, for example "5 minutes ago".
Microsoft ADO: 28737486

How I did it
Create the reference file at the start of the script, and don't update it in find_files.

How to verify it
Run end to end test: show_techsupport/test_auto_techsupport.py
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #3441

mssonicbld pushed a commit to mssonicbld/sonic-utilities that referenced this pull request Jul 23, 2024
What I did
Show techsupport is designed to collect logs and core files since given date.
I find that some core files are missing when given date is relative, for example "5 minutes ago".
Microsoft ADO: 28737486

How I did it
Create the reference file at the start of the script, and don't update it in find_files.

How to verify it
Run end to end test: show_techsupport/test_auto_techsupport.py
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #3442

mssonicbld pushed a commit that referenced this pull request Jul 24, 2024
What I did
Show techsupport is designed to collect logs and core files since given date.
I find that some core files are missing when given date is relative, for example "5 minutes ago".
Microsoft ADO: 28737486

How I did it
Create the reference file at the start of the script, and don't update it in find_files.

How to verify it
Run end to end test: show_techsupport/test_auto_techsupport.py
mssonicbld pushed a commit that referenced this pull request Jul 24, 2024
What I did
Show techsupport is designed to collect logs and core files since given date.
I find that some core files are missing when given date is relative, for example "5 minutes ago".
Microsoft ADO: 28737486

How I did it
Create the reference file at the start of the script, and don't update it in find_files.

How to verify it
Run end to end test: show_techsupport/test_auto_techsupport.py
mssonicbld pushed a commit that referenced this pull request Jul 24, 2024
What I did
Show techsupport is designed to collect logs and core files since given date.
I find that some core files are missing when given date is relative, for example "5 minutes ago".
Microsoft ADO: 28737486

How I did it
Create the reference file at the start of the script, and don't update it in find_files.

How to verify it
Run end to end test: show_techsupport/test_auto_techsupport.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants