Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202305] Input check for timeout in generate_dump (#2925) #3429

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

maipbui
Copy link
Contributor

@maipbui maipbui commented Jul 18, 2024

Cherry-pick #2925
ADO 28548370

What I did

Added input check for argument "-t" in generate_dump script

How I did it

Made sure only integer values can be received for this argument

How to verify it

Call generate_dump -t with non-integer values

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

#### What I did
Added input check for argument "-t" in generate_dump script
#### How I did it
Made sure only integer values can be received for this argument
#### How to verify it
Call generate_dump -t with non-integer values
Copy link
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 039f853 into sonic-net:202305 Jul 18, 2024
5 checks passed
@maipbui maipbui deleted the cherry_pick_gendump_202305 branch July 18, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants