[generate_dump] Improve generate_dump script to remove secrets from golden_config_db.json and old_config files #3390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganglyu
reviewed
Jul 2, 2024
| # Remove secret from /etc/sonic/golden_config_db.json | ||
| remove_secret_from_config_db_dump_file $dumppath/etc/sonic/golden_config_db.json | ||
|
|
||
| # Remove secret from /etc/sonic/old_config/ |
There was a problem hiding this comment.
No, this comments is for next 3 lines of code:
Remove snmp community string from old_config/snmp.yml
Remove secret from /etc/sonic/config_db.json
Remove secret from /etc/sonic/golden_config_db.json
ganglyu
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve generate_dump script to remove secrets from golden_config_db.json and old_config files
What I did
How I did it
How to verify it
Work item tracking
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)