Update TRANSCEIVER_FIRMWARE_INFO table for all targets in sfputil #3370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihir Patel <[email protected]>
prgeor
approved these changes
Jun 18, 2024
|
@StormLiangMS @yxieca @bingwang-ms Can you please help in merging this to 202305, 202311 and 202405 branches? |
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Jun 20, 2024
…nic-net#3370) Signed-off-by: Mihir Patel <[email protected]>
|
Cherry-pick PR to 202311: #3380 |
mssonicbld
pushed a commit
that referenced
this pull request
Jun 20, 2024
) Signed-off-by: Mihir Patel <[email protected]>
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Jun 21, 2024
…nic-net#3370) Signed-off-by: Mihir Patel <[email protected]>
|
Cherry-pick PR to 202305: #3382 |
|
@StormLiangMS I have tested the changes on 202305. |
mssonicbld
pushed a commit
that referenced
this pull request
Jun 21, 2024
) Signed-off-by: Mihir Patel <[email protected]>
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Jul 12, 2024
…nic-net#3370) Signed-off-by: Mihir Patel <[email protected]>
|
Cherry-pick PR to 202405: #3415 |
mssonicbld
pushed a commit
that referenced
this pull request
Jul 12, 2024
) Signed-off-by: Mihir Patel <[email protected]>
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
For transceivers which are CMIS target FW upgrade capable, sfputil needs to update FW version for all targets as part of firmware download, run and commit.
However, the current function update_firmware_info_to_state_db updates the firmware info to redis-db only for target 0.
MSFT ADO - 27920760
How I did it
Updating the active, inactive firmware versions for all sides. Also, updating the server firmware version for E1 and E2.
How to verify it
Ran the below sequence and ensured that the firmware info is updated for all targets in redis-db.
Also, tested the changes on transceiver which is not target FW upgradable.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)