Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick][202311] Show running config when bgp is down #3315

Merged
merged 2 commits into from
May 21, 2024

Conversation

wen587
Copy link
Contributor

@wen587 wen587 commented May 10, 2024

cherry pick conflict for #3313

What I did

How I did it

How to verify it

  • output of show run all before fix:
admin@bjw-can-7260-8:~$ show ver

SONiC Software Version: SONiC.20231110.10
...
admin@bjw-can-7260-8:~$ docker kill bgp
bgp
admin@bjw-can-7260-8:~$ show run all
Error response from daemon: Container 94f750dbed0fdd990bb34c302c52f0fe16ec34d2092d3ff754500fcc647744bf is not running

admin@bjw-can-7260-8:~$ 
  • output of show run all after fix:
admin@bjw-can-7260-8:~$ docker kill bgp
bgp
admin@bjw-can-7260-8:~$ show run all | more
Error response from daemon: Container 94f750dbed0fdd990bb34c302c52f0fe16ec34d2092d3ff754500fcc647744bf is not running

{
    "ACL_TABLE": {
        "DATAACL": {
            "policy_desc": "DATAACL",
            "ports": [
                "PortChannel101",
                "PortChannel102",
                "PortChannel103",

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@stephenxs
Copy link
Collaborator

@wen587 can you fix the ut failures?

@wen587
Copy link
Contributor Author

wen587 commented May 13, 2024

@wen587 can you fix the ut failures?

Hi, I am waiting for master PR review.

@wen587 wen587 marked this pull request as ready for review May 16, 2024 06:24
@yxieca yxieca merged commit 673da6b into sonic-net:202311 May 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants