Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202311][graceful reboot] Add the pre_reboot_hook script execution, add the watchdog arm before the reboot #3204

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

vadymhlushko-mlnx
Copy link
Contributor

@vadymhlushko-mlnx vadymhlushko-mlnx commented Mar 11, 2024

DEPENDS ON: [202311][graceful reboot] Rename the platform_reboot to the pre_reboot_hook, remove the sysfs power cycle #18325

What I did

Add the pre_reboot_hook script execution, add the watchdog arm before the reboot, in order to support the graceful reboot instead of the sysfs power cycle, to avoid filesystem corruption.

How I did it

Modify the scripts/reboot

How to verify it

  1. Start watching logs by using show log -f and journalctl -p debug -f
  2. Execute the reboot command from the switch CLI
  3. Check in logs that all systemd services terminated correctly

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@liat-grozovik
Copy link
Collaborator

@yxieca kindly reminder, this is a major fix needed for 202311

@vadymhlushko-mlnx
Copy link
Contributor Author

vadymhlushko-mlnx commented Apr 11, 2024

@yxieca, @prgeor kind reminder to merge, the same changes were already merged into master

@yxieca yxieca merged commit 21f69fb into sonic-net:202311 Apr 12, 2024
5 checks passed
liat-grozovik pushed a commit that referenced this pull request Sep 3, 2024
- What I did
Add back the support to call reboot -f
The support for this option was accidentally removed as part of this PR #3203
The same PR for 202311 doesn't have this mistake - #3204

- How I did it

- How to verify it
Call reboot -f
mssonicbld pushed a commit to mssonicbld/sonic-utilities that referenced this pull request Sep 6, 2024
- What I did
Add back the support to call reboot -f
The support for this option was accidentally removed as part of this PR sonic-net#3203
The same PR for 202311 doesn't have this mistake - sonic-net#3204

- How I did it

- How to verify it
Call reboot -f
mssonicbld pushed a commit that referenced this pull request Sep 6, 2024
- What I did
Add back the support to call reboot -f
The support for this option was accidentally removed as part of this PR #3203
The same PR for 202311 doesn't have this mistake - #3204

- How I did it

- How to verify it
Call reboot -f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants