[fast/warm-reboot] Put ERR message in syslog when a failure is seen #3186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyyeh
approved these changes
Mar 2, 2024
saiarcot895
approved these changes
Mar 2, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Mar 11, 2024
…onic-net#3186) MSFT ADO: 26918588 This change is to add ERR logs generated during warm-reboot script to syslog. Currently the ERR logs are sent in stdout and a corresponding entry is not added to syslog. This makes it difficult to debug issues when stdout is not readily available. How I did it Modified existing error function to add the log entry to syslog. How to verify it Verified manually on physical device
|
Cherry-pick PR to 202305: #3206 |
mssonicbld
pushed a commit
that referenced
this pull request
Mar 11, 2024
…3186) MSFT ADO: 26918588 This change is to add ERR logs generated during warm-reboot script to syslog. Currently the ERR logs are sent in stdout and a corresponding entry is not added to syslog. This makes it difficult to debug issues when stdout is not readily available. How I did it Modified existing error function to add the log entry to syslog. How to verify it Verified manually on physical device
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Mar 21, 2024
…onic-net#3186) MSFT ADO: 26918588 This change is to add ERR logs generated during warm-reboot script to syslog. Currently the ERR logs are sent in stdout and a corresponding entry is not added to syslog. This makes it difficult to debug issues when stdout is not readily available. How I did it Modified existing error function to add the log entry to syslog. How to verify it Verified manually on physical device
|
Cherry-pick PR to 202311: #3228 |
mssonicbld
pushed a commit
that referenced
this pull request
Mar 21, 2024
…3186) MSFT ADO: 26918588 This change is to add ERR logs generated during warm-reboot script to syslog. Currently the ERR logs are sent in stdout and a corresponding entry is not added to syslog. This makes it difficult to debug issues when stdout is not readily available. How I did it Modified existing error function to add the log entry to syslog. How to verify it Verified manually on physical device
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
MSFT ADO: 26918588
This change is to add ERR logs generated during warm-reboot script to syslog.
Currently the ERR logs are sent in stdout and a corresponding entry is not added to syslog.
This makes it difficult to debug issues when stdout is not readily available.
How I did it
Modified existing error function to add the log entry to syslog.
How to verify it
Verified manually on physical device
W/o this fix:
Simulated a failure and confirmed that error is not captured in syslog.
W/ this change:
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)