[chassis]: Support show ip bgp summary to display without error when no external neighbors are configured on chassis LC #3099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdosi
approved these changes
Jan 5, 2024
|
Removed "Request for 202205 branch" label as we will cherry-pick this directly to the msft repo 202205 branch instead, |
|
PR to Cherry-pick to msft repo: |
gechiang
added
the
included in chassis for 202205 branch
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Jan 18, 2024
…no external neighbors are configured on chassis LC (sonic-net#3099) Support show ip bgp summary to display without error when no external neighbors are configured on chassis LC
|
Cherry-pick PR to 202305: #3125 |
mssonicbld
pushed a commit
that referenced
this pull request
Jan 18, 2024
…no external neighbors are configured on chassis LC (#3099) Support show ip bgp summary to display without error when no external neighbors are configured on chassis LC
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Feb 2, 2024
…no external neighbors are configured on chassis LC (sonic-net#3099) Support show ip bgp summary to display without error when no external neighbors are configured on chassis LC
|
Cherry-pick PR to 202311: #3143 |
mssonicbld
pushed a commit
that referenced
this pull request
Feb 2, 2024
…no external neighbors are configured on chassis LC (#3099) Support show ip bgp summary to display without error when no external neighbors are configured on chassis LC
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
arlakshm
added a commit
that referenced
this pull request
Feb 8, 2024
…SIC (#3158) This PR #3099 fixes the case where on chassis Linecard there are no BGP neighbors. However, if the Linecard has neighbors on one ASIC but not on other, the command show bgp summary displayed no neighbors. This PR fixes this. How I did it Add check in bgp_util to create empty peer list only once Add UT to cover this case
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Feb 12, 2024
…SIC (sonic-net#3158) This PR sonic-net#3099 fixes the case where on chassis Linecard there are no BGP neighbors. However, if the Linecard has neighbors on one ASIC but not on other, the command show bgp summary displayed no neighbors. This PR fixes this. How I did it Add check in bgp_util to create empty peer list only once Add UT to cover this case
mssonicbld
pushed a commit
that referenced
this pull request
Feb 12, 2024
…SIC (#3158) This PR #3099 fixes the case where on chassis Linecard there are no BGP neighbors. However, if the Linecard has neighbors on one ASIC but not on other, the command show bgp summary displayed no neighbors. This PR fixes this. How I did it Add check in bgp_util to create empty peer list only once Add UT to cover this case
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Apr 26, 2024
…SIC (sonic-net#3158) This PR sonic-net#3099 fixes the case where on chassis Linecard there are no BGP neighbors. However, if the Linecard has neighbors on one ASIC but not on other, the command show bgp summary displayed no neighbors. This PR fixes this. How I did it Add check in bgp_util to create empty peer list only once Add UT to cover this case
mssonicbld
pushed a commit
that referenced
this pull request
Apr 26, 2024
…SIC (#3158) This PR #3099 fixes the case where on chassis Linecard there are no BGP neighbors. However, if the Linecard has neighbors on one ASIC but not on other, the command show bgp summary displayed no neighbors. This PR fixes this. How I did it Add check in bgp_util to create empty peer list only once Add UT to cover this case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Support show ip bgp summary to display without error when no external neighbors are configured on chassis LC
Fixes: #3098
MSFT ADO: 26238398:How I did it
On Chassis linecard with no external neighbors the
show ip bgp summaryfails because the on chassis linecard there are internal iBGP sessions are present so frr output has this information.With this fix with this case is handled so that the commands do not display any error but instead we are display the below output
How to verify it
UT and chassis and test the command on pizza box sonic
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)