Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disable/enable syslog rate limit feature #3072

Merged

Conversation

Junchao-Mellanox
Copy link
Collaborator

@Junchao-Mellanox Junchao-Mellanox commented Dec 8, 2023

Depends on PR sonic-net/sonic-buildimage#17458

What I did

Add CLIs to enable/disable containercfgd to optimize warm/fast boot path

How I did it

Add CLIs to enable/disable containercfgd

How to verify it

unit test
manual test

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@yxieca
Copy link
Contributor

yxieca commented Dec 8, 2023

@Junchao-Mellanox can you add some more unit test code to improve the coverage?

@liat-grozovik
Copy link
Collaborator

@yxieca can you please help to review?

@liat-grozovik
Copy link
Collaborator

@Junchao-Mellanox should you add it to the command reference guide as a new command?

@Junchao-Mellanox
Copy link
Collaborator Author

@Junchao-Mellanox should you add it to the command reference guide as a new command?

I already added it.

@StormLiangMS StormLiangMS merged commit 56dafb0 into sonic-net:master Dec 25, 2023
5 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-utilities that referenced this pull request Dec 25, 2023
Depends on PR sonic-net/sonic-buildimage#17458

What I did
Add CLIs to enable/disable containercfgd to optimize warm/fast boot path

How I did it
Add CLIs to enable/disable containercfgd

How to verify it
unit test
manual test
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #3101

mssonicbld pushed a commit that referenced this pull request Dec 25, 2023
Depends on PR sonic-net/sonic-buildimage#17458

What I did
Add CLIs to enable/disable containercfgd to optimize warm/fast boot path

How I did it
Add CLIs to enable/disable containercfgd

How to verify it
unit test
manual test
@Junchao-Mellanox Junchao-Mellanox deleted the master-disable-rate-final branch January 5, 2024 08:51
mssonicbld pushed a commit to mssonicbld/sonic-utilities that referenced this pull request Jan 10, 2024
Depends on PR sonic-net/sonic-buildimage#17458

What I did
Add CLIs to enable/disable containercfgd to optimize warm/fast boot path

How I did it
Add CLIs to enable/disable containercfgd

How to verify it
unit test
manual test
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #3113

mssonicbld pushed a commit that referenced this pull request Jan 10, 2024
Depends on PR sonic-net/sonic-buildimage#17458

What I did
Add CLIs to enable/disable containercfgd to optimize warm/fast boot path

How I did it
Add CLIs to enable/disable containercfgd

How to verify it
unit test
manual test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants