Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container rsyslog.conf to the sys dump #3039

Merged
merged 2 commits into from
Nov 19, 2023

Conversation

vivekrnv
Copy link
Contributor

@vivekrnv vivekrnv commented Nov 15, 2023

What I did

Added a new directory to generate_dump for collecting any container specific config files etc to the sys dump. For now only the rsyslog.conf is added

How I did it

How to verify it

Run the dump and see if the rsyslogd files are present

root@r-leopard-41:/home/admin# tree -a sonic_dump_r-leopard-41_20230815_013600/dump/container_dumps/
sonic_dump_r-leopard-41_20230815_013600/dump/container_dumps/
├── bgp
│   └── rsyslog.conf
├── database
│   └── rsyslog.conf
├── dhcp_relay
│   └── rsyslog.conf
├── eventd
│   └── rsyslog.conf
├── lldp
│   └── rsyslog.conf
├── mgmt-framework
│   └── rsyslog.conf
├── pmon
│   └── rsyslog.conf
├── radv
│   └── rsyslog.conf
├── snmp
│   └── rsyslog.conf
├── swss
│   └── rsyslog.conf
├── syncd
│   └── rsyslog.conf
├── teamd
│   └── rsyslog.conf
└── telemetry
    └── rsyslog.conf

13 directories, 13 files

Tested branch (Please provide the tested image version)

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@dgsudharsan
Copy link
Collaborator

@StormLiangMS This is debug the issues sonic-net/sonic-buildimage#15152 sonic-net/sonic-buildimage#17172 and today we lack critical information in containers.

Copy link
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit cfd2dd3 into sonic-net:master Nov 19, 2023
5 checks passed
StormLiangMS pushed a commit that referenced this pull request Nov 19, 2023
What I did
Added a new directory to generate_dump for collecting any container specific config files etc to the sys dump. For now only the rsyslog.conf is added

How I did it
How to verify it
Run the dump and see if the rsyslogd files are present

root@r-leopard-41:/home/admin# tree -a sonic_dump_r-leopard-41_20230815_013600/dump/container_dumps/
sonic_dump_r-leopard-41_20230815_013600/dump/container_dumps/
├── bgp
│   └── rsyslog.conf
├── database
│   └── rsyslog.conf
├── dhcp_relay
│   └── rsyslog.conf
├── eventd
│   └── rsyslog.conf
├── lldp
│   └── rsyslog.conf
├── mgmt-framework
│   └── rsyslog.conf
├── pmon
│   └── rsyslog.conf
├── radv
│   └── rsyslog.conf
├── snmp
│   └── rsyslog.conf
├── swss
│   └── rsyslog.conf
├── syncd
│   └── rsyslog.conf
├── teamd
│   └── rsyslog.conf
└── telemetry
    └── rsyslog.conf

13 directories, 13 files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants