[vlan][dhcp_relay] Fix error while delete vlan #2987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaqiangz
force-pushed
the
master_fix_vlan_cli
branch
from
9adeb5e
to
4a2c518
Compare
yaqiangz
force-pushed
the
master_fix_vlan_cli
branch
from
4a2c518
to
cc450ee
Compare
Blueve
approved these changes
Sep 20, 2023
|
@StormLiangMS Could you pls help to backport, msft work item No is 25218076 |
StormLiangMS
pushed a commit
that referenced
this pull request
Sep 21, 2023
Why I did Use static str to run_command would encounter error because change in this PR: #2718. How I did it Change command from static str to list. How to verify it UT passed. Build whl and install in testbed. Signed-off-by: Yaqiang Zhu <[email protected]>
JunhongMao
pushed a commit
to JunhongMao/sonic-utilities
that referenced
this pull request
Oct 4, 2023
Why I did Use static str to run_command would encounter error because change in this PR: sonic-net#2718. How I did it Change command from static str to list. How to verify it UT passed. Build whl and install in testbed. Signed-off-by: Yaqiang Zhu <[email protected]>
StormLiangMS
added
Included in 202305 Branch
and removed
Cherry Pick Conflict_202305
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT work item: 25218076
Why I did
Use static str to run_command would encounter error because change in this PR: #2718.
How I did it
Change command from static str to list.
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)