-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix del vlan command #2982
Merged
Merged
Fix del vlan command #2982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mai Bui <[email protected]>
qiluo-msft
previously approved these changes
Sep 14, 2023
Signed-off-by: Mai Bui <[email protected]>
qiluo-msft
approved these changes
Sep 14, 2023
@maipbui This may have conflicts for 202305. Can you please raise a separate PR? |
yaqiangz
pushed a commit
to yaqiangz/sonic-utilities
that referenced
this pull request
Sep 20, 2023
Resolves sonic-net/sonic-buildimage#16542 Update str -> list[str] commands which were missed in sonic-net#2718 Pass UT. Manual test, issue resolved, tested in internal.79435802-3bbd91c86e version Signed-off-by: Mai Bui <[email protected]>
@maipbui cherry pick conflict, pls file separate PR for 202305. |
cherry-pick 202305 PR: #2995 |
JunhongMao
pushed a commit
to JunhongMao/sonic-utilities
that referenced
this pull request
Oct 4, 2023
Resolves sonic-net/sonic-buildimage#16542 #### What I did Update str -> list[str] commands which were missed in sonic-net#2718 #### How I did it #### How to verify it Pass UT. Manual test, issue resolved, tested in internal.79435802-3bbd91c86e version Signed-off-by: Mai Bui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADO: 25535864
Resolves sonic-net/sonic-buildimage#16542
Cherry-pick
What I did
Update str -> list[str] commands which were missed in #2718
How I did it
How to verify it
Pass UT. Manual test, issue resolved, tested in internal.79435802-3bbd91c86e version
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)