Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix del vlan command #2982

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Fix del vlan command #2982

merged 2 commits into from
Sep 15, 2023

Conversation

maipbui
Copy link
Contributor

@maipbui maipbui commented Sep 14, 2023

ADO: 25535864

Resolves sonic-net/sonic-buildimage#16542
Cherry-pick

What I did

Update str -> list[str] commands which were missed in #2718

How I did it

How to verify it

Pass UT. Manual test, issue resolved, tested in internal.79435802-3bbd91c86e version

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Signed-off-by: Mai Bui <[email protected]>
qiluo-msft
qiluo-msft previously approved these changes Sep 14, 2023
Signed-off-by: Mai Bui <[email protected]>
@maipbui maipbui merged commit 5729028 into sonic-net:master Sep 15, 2023
4 checks passed
@maipbui maipbui deleted the fix_del_vlan branch September 15, 2023 14:19
@dgsudharsan
Copy link
Collaborator

@maipbui This may have conflicts for 202305. Can you please raise a separate PR?

yaqiangz pushed a commit to yaqiangz/sonic-utilities that referenced this pull request Sep 20, 2023
Resolves sonic-net/sonic-buildimage#16542
Update str -> list[str] commands which were missed in sonic-net#2718
Pass UT. Manual test, issue resolved, tested in internal.79435802-3bbd91c86e version
Signed-off-by: Mai Bui <[email protected]>
@StormLiangMS
Copy link
Contributor

@maipbui cherry pick conflict, pls file separate PR for 202305.

@maipbui
Copy link
Contributor Author

maipbui commented Sep 21, 2023

cherry-pick 202305 PR: #2995

JunhongMao pushed a commit to JunhongMao/sonic-utilities that referenced this pull request Oct 4, 2023
Resolves sonic-net/sonic-buildimage#16542
#### What I did
Update str -> list[str] commands which were missed in sonic-net#2718
#### How I did it
#### How to verify it
Pass UT. Manual test, issue resolved, tested in internal.79435802-3bbd91c86e version
Signed-off-by: Mai Bui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Vlan] config vlan del command results in traceback with supervisorctl status ndppd command failing in swss
4 participants