Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to display only nonzero queue counter. #2978

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

abdosi
Copy link
Contributor

@abdosi abdosi commented Sep 12, 2023

What I did:
Added new option --nonzero to display given {port,queue} or {system-port, voq} counter only if any of counter value is non zero.

Microsoft ADO: 24888995

Why I did:
Adding this option is useful during debugging specially on VOQ system that can have many {System port, Queue} on one LC running SONiC instance.

How I verify:
UT has been modified and updated
Manual Verification on chassis systems.

New commads:
show queue counters --nonzero
queuestat -nz

@abdosi abdosi added the included in chassis for 202205 branch indicate that this PR got merged into the "chassis for 202205 branch" label Sep 14, 2023
@abdosi abdosi merged commit e2c1841 into sonic-net:master Sep 14, 2023
4 checks passed
@prsunny
Copy link
Contributor

prsunny commented Sep 18, 2023

@abdosi , would you please provide output of the new command in description?

@StormLiangMS
Copy link
Contributor

@abdosi cherry pick conflict, pls file separate PR for 202305.

@abdosi
Copy link
Contributor Author

abdosi commented Sep 29, 2023

@abdosi , would you please provide output of the new command in description?

updated.

JunhongMao pushed a commit to JunhongMao/sonic-utilities that referenced this pull request Oct 4, 2023
Added new option --nonzero to display given {port,queue} or {system-port, voq} counter only if any of counter value is non zero.
@StormLiangMS
Copy link
Contributor

@abdosi remind for conflict with 202305 cherry pick

abdosi added a commit to abdosi/sonic-utilities that referenced this pull request Nov 17, 2023
Added new option --nonzero to display given {port,queue} or {system-port, voq} counter only if any of counter value is non zero.

Signed-off-by: Abhishek Dosi <[email protected]>
@abdosi
Copy link
Contributor Author

abdosi commented Nov 17, 2023

@abdosi remind for conflict with 202305 cherry pick

@StormLiangMS 202305 PR: #3046

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants