Complete Platform Validator PR #2857
Conversation
| if device_info.get_sonic_version_info()['asic_type'] == 'cisco-8000': | ||
| asic = "cisco-8000" | ||
| elif device_info.get_sonic_version_info()['asic_type'] == 'vs': | ||
| asic = "td2" |
There was a problem hiding this comment.
This is not always true. Please check https://github.com/sonic-net/sonic-buildimage/blob/220ea74cbb7e5cc783a27d7ca9f966899d81b7b3/platform/vs/docker-sonic-vs/Dockerfile.j2#L176 #Closed
There was a problem hiding this comment.
Updated the PR to fully consider vs hwskus
| if asic_type == 'broadcom' or asic_type == 'vs': | ||
| broadcom_asics = asic_mapping["broadcom_asics"] | ||
| for asic_shorthand, hwskus in broadcom_asics.items(): | ||
| if asic != "unknown": |
There was a problem hiding this comment.
asic is set to "unknown" at the start of the function. It remains unknown until one of the specified asic types in the table is identified. The purpose of this particular check is to stop iterating over all possible broadcom asics once the asic is already identified.
There was a problem hiding this comment.
If it is already identified as spc1, you can return immediately.
There was a problem hiding this comment.
Changed to return spc1 immediately
|
PR to cherry-pick to 202205 branch: #2883 |
Cherry-pick PR 2692, 2818, and 2857 to 202205
* [GCU] Complete RDMA Platform Validator PR (#2857) Cherry-pick PR 2692, 2818, and 2857 to 202205
This reverts commit 788db8c.
…ic-net#2883) * [GCU] Complete RDMA Platform Validator PR (sonic-net#2857) Cherry-pick PR 2692, 2818, and 2857 to 202205
Cherry-pick PR #2692 (set up test infrastructure used in later PR 2857), #2857 (platform validator PR), #2913 (edge case fix), #2951, #3018 (add support for new Mellanox HwSKU in conf file) This change stops GCU from modifying a protected RDMA field. Signed-off-by: Stephen Sun <[email protected]> Co-authored-by: Stephen Sun <[email protected]>
Original platform validator PR https://github.com/sonic-net/sonic-utilities/pull/2791/checks?check_run_id=12708751588 was merged and reverted due to unexpected test case behavior blocking submodule advance. This was fixed by specifically considering the virtual switch platform and identifying the appropriate ASIC. Now, this platform validator PR brings back the original changes
ADO 17747379