[config]config reload should generate sysinfo if missing #2778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Apr 8, 2023
| @@ -1560,6 +1560,17 @@ def reload(db, filename, yes, load_sysinfo, no_service_restart, force, file_form | |||
| click.echo("The config file {} doesn't exist".format(file)) | |||
| continue | |||
|
|
|||
| if file_format == 'config_db': | |||
There was a problem hiding this comment.
Is this feature already implement by argument load_sysinfo? #Closed
There was a problem hiding this comment.
Yes. The purpose of the PR is to keep the CLI cmd identical for Golden Config reload.
From NDM team's knowledge, they don't have such info from their side.
Is it also a bug inside override_config logic? In reply to: 1502458655 Refers to: config/main.py:1693 in f5f7bd4. [](commit_id = f5f7bd4, deletion_comment = False) |
I think so. I will submit a fix in this PR: #2738 |
qiluo-msft
reviewed
Apr 11, 2023
qiluo-msft
reviewed
Apr 11, 2023
qiluo-msft
reviewed
Apr 11, 2023
qiluo-msft
approved these changes
Apr 17, 2023
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
May 1, 2023
Update sonic-utilities submodule pointer to include the following: * 88ffb167 [config]config reload should generate sysinfo if missing ([sonic-net#2778](sonic-net/sonic-utilities#2778)) * 7443b9e5 [sonic-package-manager] support extension with multiple YANG modules ([sonic-net#2752](sonic-net/sonic-utilities#2752)) * 522c3a9e [sonic-package-manager] add support for multiple CLI plugin files ([sonic-net#2753](sonic-net/sonic-utilities#2753)) * b38fcfd1 [show][muxcable] fix RC ([sonic-net#2812](sonic-net/sonic-utilities#2812)) * 7e24463f [chassis]: remote cli commands infra for sonic chassis ([sonic-net#2701](sonic-net/sonic-utilities#2701)) * bee593e4 [DPB]Fixing typo in config breakout output ([sonic-net#2802](sonic-net/sonic-utilities#2802)) * ada603c5 [config]Support multi-asic Golden Config override ([sonic-net#2738](sonic-net/sonic-utilities#2738)) * 88a7daa8 [show][barefoot] replace shell=True ([sonic-net#2699](sonic-net/sonic-utilities#2699)) * 5e99edb5 [sonic_package_manager] replace shell=True ([sonic-net#2726](sonic-net/sonic-utilities#2726)) * b547bb45 [acl-loader] Only add default deny rule when table is L3 or L3V6 ([sonic-net#2796](sonic-net/sonic-utilities#2796)) Signed-off-by: dprital <[email protected]>
10 tasks
yxieca
pushed a commit
that referenced
this pull request
May 4, 2023
What I did Missing platform and mac in CONFIG_DB will result in container failure. We should make the config reload generate those info if missing. How I did it Add missing sys info if config_db.json doesn't contain it. How to verify it Unit test
wen587
added a commit
to wen587/sonic-utilities
that referenced
this pull request
Jun 5, 2023
…ic-net#2778)" This reverts commit 88ffb16.
wen587
added a commit
that referenced
this pull request
Jun 5, 2023
yxieca
pushed a commit
that referenced
this pull request
Jun 15, 2023
pdhruv-marvell
pushed a commit
to pdhruv-marvell/sonic-utilities
that referenced
this pull request
Aug 23, 2023
…ic-net#2778)" (sonic-net#2865) This reverts commit 88ffb16.
wen587
added a commit
to wen587/sonic-utilities
that referenced
this pull request
Oct 31, 2023
…ing (sonic-net#2778)" (sonic-net#2865)" This reverts commit 7d803ae.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Missing platform and mac in CONFIG_DB will result in container failure. We should make the
config reloadgenerate those info if missing.How I did it
Add missing sys info if config_db.json doesn't contain it.
How to verify it
Unit test
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)