Add UT to check sonic installer does not depend on database #2401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 26, 2022
|
In the section "How did you verify/test it?", you mentioned the positive testcase. How about the negative case? Previously sonic installer does depends on database, so the new testcase should catch the bug. |
qiluo-msft
changed the title
qiluo-msft
approved these changes
Sep 29, 2022
EdenGri
pushed a commit
to EdenGri/sonic-utilities
that referenced
this pull request
Oct 12, 2022
…t#2401) ### Description of PR Add new test cases to test sonic-installer does not depends on database docker. ### Type of change - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [x] Test case(new/improvement) ### Back port request ### Approach #### What is the motivation for this PR? Add new test cases to test sonic-installer does not depends on database docker. #### How did you do it? Add new test case to cover user scenarios. #### How did you verify/test it? Run new UT make sure they are all pass. Make sure all current UT not break during merge validation. #### Any platform specific information? N/A #### Supported testbed topology if it's a new test case?.
mdanish-kh
pushed a commit
to hamnarauf/sonic-utilities
that referenced
this pull request
Oct 22, 2022
…t#2401) ### Description of PR Add new test cases to test sonic-installer does not depends on database docker. ### Type of change - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [x] Test case(new/improvement) ### Back port request ### Approach #### What is the motivation for this PR? Add new test cases to test sonic-installer does not depends on database docker. #### How did you do it? Add new test case to cover user scenarios. #### How did you verify/test it? Run new UT make sure they are all pass. Make sure all current UT not break during merge validation. #### Any platform specific information? N/A #### Supported testbed topology if it's a new test case?.
preetham-singh
pushed a commit
to preetham-singh/sonic-utilities
that referenced
this pull request
Nov 21, 2022
…t#2401) ### Description of PR Add new test cases to test sonic-installer does not depends on database docker. ### Type of change - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [x] Test case(new/improvement) ### Back port request ### Approach #### What is the motivation for this PR? Add new test cases to test sonic-installer does not depends on database docker. #### How did you do it? Add new test case to cover user scenarios. #### How did you verify/test it? Run new UT make sure they are all pass. Make sure all current UT not break during merge validation. #### Any platform specific information? N/A #### Supported testbed topology if it's a new test case?.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Add new test cases to test sonic-installer does not depends on database docker.
Type of change
Back port request
Approach
What is the motivation for this PR?
Add new test cases to test sonic-installer does not depends on database docker.
How did you do it?
Add new test case to cover user scenarios.
How did you verify/test it?
Run new UT make sure they are all pass.
Make sure all current UT not break during merge validation.
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?.