Fix vrf UT failed issue #2309
Merged
Fix vrf UT failed issue #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/ip_config_test.py
Outdated
| print(result.exit_code, result.output) | ||
| assert result.exit_code == 0 | ||
|
|
||
| def test_intf_vrf_bind_unbind(self): |
There was a problem hiding this comment.
I think we can remove this duplicate testcase.
There was a problem hiding this comment.
Fixed, dupe by copy paste
preetham-singh
previously approved these changes
Aug 12, 2022
qiluo-msft
approved these changes
Aug 12, 2022
7 tasks
yxieca
pushed a commit
that referenced
this pull request
Sep 1, 2022
#### What I did
Fix VRF bind/unbind UT failed issue.
#### How I did it
Mock DBInterface.close() method.
#### How to verify it
Add new UT.
Pass all UT.
#### Previous command output (if the output of a command-line utility has changed)
#### New command output (if the output of a command-line utility has changed)
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Sep 7, 2022
Update sonic-utilities submodule pointer to include the following: * [route_check]: Ignore standalone tunnel routes (sonic-net#2325) ([sonic-net#2346](sonic-net/sonic-utilities#2346)) * [VRF]Adding CLI checks to ensure Vrf is valid in interface bind and static route commands ([sonic-net#2333](sonic-net/sonic-utilities#2333)) * Subinterface vrf bind issue fix ([sonic-net#2211](sonic-net/sonic-utilities#2211)) * [decode-syseeprom] Fix setting use_db based on support_eeprom_db ([sonic-net#2270](sonic-net/sonic-utilities#2270)) * Fix vrf UT failed issue ([sonic-net#2309](sonic-net/sonic-utilities#2309)) Signed-off-by: dprital <[email protected]>
7 tasks
yxieca
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Sep 8, 2022
Update sonic-utilities submodule pointer to include the following: * [route_check]: Ignore standalone tunnel routes (#2325) ([#2346](sonic-net/sonic-utilities#2346)) * [VRF]Adding CLI checks to ensure Vrf is valid in interface bind and static route commands ([#2333](sonic-net/sonic-utilities#2333)) * Subinterface vrf bind issue fix ([#2211](sonic-net/sonic-utilities#2211)) * [decode-syseeprom] Fix setting use_db based on support_eeprom_db ([#2270](sonic-net/sonic-utilities#2270)) * Fix vrf UT failed issue ([#2309](sonic-net/sonic-utilities#2309)) Signed-off-by: dprital <[email protected]> Signed-off-by: dprital <[email protected]>
preetham-singh
pushed a commit
to preetham-singh/sonic-utilities
that referenced
this pull request
Nov 21, 2022
#### What I did
Fix VRF bind/unbind UT failed issue.
#### How I did it
Mock DBInterface.close() method.
#### How to verify it
Add new UT.
Pass all UT.
#### Previous command output (if the output of a command-line utility has changed)
#### New command output (if the output of a command-line utility has changed)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)