Fix UT failed cause by change pycommon to use swsscommon #2085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR check failed because UT issue in sonic-swss, which already have a PR to fix the issue: |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ak_with_swsscommon
|
Could you add "UT failed" message into PR description? |
PR description updated. |
qiluo-msft
approved these changes
Mar 17, 2022
vivekrnv
pushed a commit
to vivekrnv/sonic-utilities
that referenced
this pull request
Jun 23, 2022
) Fix UT failed cause by change sonic_py_common to use swss_common #### Description Fix UT failed cause by change sonic_py_common to use swss_common, here is UT failed message: 2022-02-28T09:26:11.4706067Z _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 2022-02-28T09:26:11.4706457Z scripts/route_check.py:556: in main 2022-02-28T09:26:11.4706805Z ret, res= check_routes() 2022-02-28T09:26:11.4707152Z scripts/route_check.py:491: in check_routes 2022-02-28T09:26:11.4707567Z rt_appl_miss = filter_out_local_interfaces(rt_appl_miss) 2022-02-28T09:26:11.4708035Z scripts/route_check.py:352: in filter_out_local_interfaces 2022-02-28T09:26:11.4708494Z chassis_local_intfs = chassis.get_chassis_local_interfaces() 2022-02-28T09:26:11.4708981Z utilities_common/chassis.py:7: in get_chassis_local_interfaces 2022-02-28T09:26:11.4709703Z chassisdb_conf=os.path.join('/usr/share/sonic/device/', platform, "chassisdb.conf") 2022-02-28T09:26:11.4710280Z /usr/lib/python3.7/posixpath.py:94: in join 2022-02-28T09:26:11.4710838Z genericpath._check_arg_types('join', a, *p) 2022-02-28T09:26:11.4711261Z _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ The UT failed because device_info.get_platform() return null, to fix this issue, add mock method for device_info.get_platform(). #### Motivation and Context pyswss will be deprecate, so sonic_py_common will changed to use swss_common. Some UT in this project failed because this change. #### How Has This Been Tested? Pass all UT and sonic-buildimage E2E test.
vivekrnv
pushed a commit
to vivekrnv/sonic-utilities
that referenced
this pull request
Jun 23, 2022
) Fix UT failed cause by change sonic_py_common to use swss_common #### Description Fix UT failed cause by change sonic_py_common to use swss_common, here is UT failed message: 2022-02-28T09:26:11.4706067Z _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 2022-02-28T09:26:11.4706457Z scripts/route_check.py:556: in main 2022-02-28T09:26:11.4706805Z ret, res= check_routes() 2022-02-28T09:26:11.4707152Z scripts/route_check.py:491: in check_routes 2022-02-28T09:26:11.4707567Z rt_appl_miss = filter_out_local_interfaces(rt_appl_miss) 2022-02-28T09:26:11.4708035Z scripts/route_check.py:352: in filter_out_local_interfaces 2022-02-28T09:26:11.4708494Z chassis_local_intfs = chassis.get_chassis_local_interfaces() 2022-02-28T09:26:11.4708981Z utilities_common/chassis.py:7: in get_chassis_local_interfaces 2022-02-28T09:26:11.4709703Z chassisdb_conf=os.path.join('/usr/share/sonic/device/', platform, "chassisdb.conf") 2022-02-28T09:26:11.4710280Z /usr/lib/python3.7/posixpath.py:94: in join 2022-02-28T09:26:11.4710838Z genericpath._check_arg_types('join', a, *p) 2022-02-28T09:26:11.4711261Z _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ The UT failed because device_info.get_platform() return null, to fix this issue, add mock method for device_info.get_platform(). #### Motivation and Context pyswss will be deprecate, so sonic_py_common will changed to use swss_common. Some UT in this project failed because this change. #### How Has This Been Tested? Pass all UT and sonic-buildimage E2E test.
liat-grozovik
pushed a commit
that referenced
this pull request
Jun 23, 2022
) (#2231) Fix UT failed cause by change sonic_py_common to use swss_common #### Description Fix UT failed cause by change sonic_py_common to use swss_common, here is UT failed message: 2022-02-28T09:26:11.4706067Z _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 2022-02-28T09:26:11.4706457Z scripts/route_check.py:556: in main 2022-02-28T09:26:11.4706805Z ret, res= check_routes() 2022-02-28T09:26:11.4707152Z scripts/route_check.py:491: in check_routes 2022-02-28T09:26:11.4707567Z rt_appl_miss = filter_out_local_interfaces(rt_appl_miss) 2022-02-28T09:26:11.4708035Z scripts/route_check.py:352: in filter_out_local_interfaces 2022-02-28T09:26:11.4708494Z chassis_local_intfs = chassis.get_chassis_local_interfaces() 2022-02-28T09:26:11.4708981Z utilities_common/chassis.py:7: in get_chassis_local_interfaces 2022-02-28T09:26:11.4709703Z chassisdb_conf=os.path.join('/usr/share/sonic/device/', platform, "chassisdb.conf") 2022-02-28T09:26:11.4710280Z /usr/lib/python3.7/posixpath.py:94: in join 2022-02-28T09:26:11.4710838Z genericpath._check_arg_types('join', a, *p) 2022-02-28T09:26:11.4711261Z _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ The UT failed because device_info.get_platform() return null, to fix this issue, add mock method for device_info.get_platform(). #### Motivation and Context pyswss will be deprecate, so sonic_py_common will changed to use swss_common. Some UT in this project failed because this change. #### How Has This Been Tested? Pass all UT and sonic-buildimage E2E test. Co-authored-by: liuh-80 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix UT failed cause by change sonic_py_common to use swss_common
Description
Motivation and Context
How Has This Been Tested?
Additional Information (Optional)