Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport [generate_dump] remove secrets from dump files #1886 to 202012 #1938

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

liuh-80
Copy link
Contributor

@liuh-80 liuh-80 commented Nov 22, 2021

Backport [generate_dump] remove secrets from dump files #1886 to 202012

What I did

Add bash functions to remove secrets from dump files.

How I did it

For tacacs key, radius key, snmp community srring, use sed command with regex to remove user secrets from dump files.
For certs, update tar command exclude list to remove those certs from dump file.

How to verify it

Run 'show techsupport' command and check secrets removed from dump files.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

…to 202012

#### What I did
    Add bash functions to remove secrets from dump files.

#### How I did it
    For tacacs key, radius key, snmp community srring, use sed command with regex to remove user secrets from dump files.
    For certs, update tar command exclude list to remove those certs from dump file.

#### How to verify it
    Run 'show techsupport' command and check secrets removed from dump files.

#### Previous command output (if the output of a command-line utility has changed)

#### New command output (if the output of a command-line utility has changed)
@liuh-80 liuh-80 requested a review from qiluo-msft November 22, 2021 02:27
@liuh-80 liuh-80 closed this Nov 22, 2021
@liuh-80 liuh-80 reopened this Nov 22, 2021
@liuh-80 liuh-80 merged commit ec9e5ee into sonic-net:202012 Nov 22, 2021
@liuh-80
Copy link
Contributor Author

liuh-80 commented Nov 22, 2021

Close by mistake, reopen and merge again.

stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 18, 2022
Submodule update for sonic-utilities with following change:

ec9e5ee Backport [generate_dump] remove secrets from dump files sonic-net#1886 to 202012 (sonic-net#1938)
ce3b856 [fdbshow]: Handle FDB cleanup gracefully. (sonic-net#1926)
1437bf2 [202012] Add DHCPv6 Relay counter and ipv6 helper CLI (sonic-net#1917)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants