-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generic_updater: Fix service validator related issues #1901
Merged
Merged
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
7863b59
ChangeApplier and unit test code.
renukamanavalan 84f493b
minor update
renukamanavalan dd337eb
fix unused import
renukamanavalan 6e0bba0
Added service validation
renukamanavalan cabcf23
Take off added code for logging
renukamanavalan a075606
Merge remote-tracking branch 'upstream/master' into updater
renukamanavalan bd7781c
fix merge
renukamanavalan f839e53
change applier & test updated for service validation
renukamanavalan beb1ea7
removed unused import
renukamanavalan fe25d2e
Added two service validators
renukamanavalan fec8f8f
move global to class; No logical code changes
renukamanavalan 7d90266
A fix in file path
renukamanavalan 91f8f7e
Merge remote-tracking branch 'upstream/master' into updater
renukamanavalan 6cd9dd8
1) Copy generic_updater_config.conf.json as part of install
renukamanavalan 5a9434b
Merge remote-tracking branch 'upstream/master' into updater
renukamanavalan 30feec2
Prune only empty tables
renukamanavalan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the filename,
generic_config_updater.conf.json
seems make more sense. It is confusing to see..config.conf..