Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show commands for SYSTEM READY #1851

Merged
merged 4 commits into from
May 20, 2022
Merged

Conversation

sg893052
Copy link
Contributor

@sg893052 sg893052 commented Oct 1, 2021

What I did

show command support for System Ready Feature Implementation .
Also sonic-package-manager support for app readiness.

"show system-health sysready-status"
"show system-health sysready-status detail"
"show system-health sysready-status brief"

How I did it

Introduce "show system-health sysready-status" click CLI with options.

How to verify it

Check the click CLIs introduced.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

root@sonic:/home/admin# show system-health sysready-status
System is ready

Service-Name                      Service-Status    App-Ready-Status    Down-Reason
--------------------------------  ----------------  ------------------  -------------
as7326-56x-pddf-platform-monitor  OK                OK                  -
auditd                            OK                OK                  -
bgp                               OK                OK                  -
caclmgrd                          OK                OK                  -
config-chassisdb                  OK                OK                  -
config-setup                      OK                OK                  -
containerd                        OK                OK                  -
cron                              OK                OK                  -
database                          OK                OK                  -
docker                            OK                OK                  -
kdump-tools                       OK                OK                  -
lldp                              OK                OK                  -
mgmt-framework                    OK                OK                  -
netfilter-persistent              OK                OK                  -
ntp                               OK                OK                  -
opennsl-modules                   OK                OK                  -
pddf-platform-init                OK                OK                  -
pmon                              OK                OK                  -
procdockerstatsd                  OK                OK                  -
radv                              OK                OK                  -
ras-mc-ctl                        OK                OK                  -
rsyslog                           OK                OK                  -
smartmontools                     OK                OK                  -
snmp                              OK                OK                  -
ssh                               OK                OK                  -
swss                              OK                OK                  -
syncd                             OK                OK                  -
teamd                             OK                OK                  -
telemetry                         OK                OK                  -
root@sonic:/home/admin#

root@sonic:/home/admin# show system-health sysready-status detail
System is ready

Service-Name                      Service-Status    App-Ready-Status    Down-Reason    AppStatus-UpdateTime
--------------------------------  ----------------  ------------------  -------------  ----------------------
as7326-56x-pddf-platform-monitor  OK                OK                  -              -
auditd                            OK                OK                  -              -
bgp                               OK                OK                  -              -
caclmgrd                          OK                OK                  -              -
config-chassisdb                  OK                OK                  -              -
config-setup                      OK                OK                  -              -
containerd                        OK                OK                  -              -
cron                              OK                OK                  -              -
database                          OK                OK                  -              -
docker                            OK                OK                  -              -
kdump-tools                       OK                OK                  -              -
lldp                              OK                OK                  -              -
mgmt-framework                    OK                OK                  -              -
netfilter-persistent              OK                OK                  -              -
ntp                               OK                OK                  -              -
opennsl-modules                   OK                OK                  -              -
pddf-platform-init                OK                OK                  -              -
pmon                              OK                OK                  -              -
procdockerstatsd                  OK                OK                  -              -
radv                              OK                OK                  -              -
ras-mc-ctl                        OK                OK                  -              -
rsyslog                           OK                OK                  -              -
smartmontools                     OK                OK                  -              -
snmp                              OK                OK                  -              -
ssh                               OK                OK                  -              -
swss                              OK                OK                  -              -
syncd                             OK                OK                  -              -
teamd                             OK                OK                  -              -
telemetry                         OK                OK                  -              -
root@sonic:/home/admin#
root@sonic:/home/admin#
root@sonic:/home/admin# show system-health sysready-status brief
System is ready

root@sonic:/home/admin#

root@sonic:/home/admin# systemctl stop bgp
root@sonic:/home/admin#
Apr 05 14:49:40.859589 System is not ready - one or more services are not up

root@sonic:/home/admin#
root@sonic:/home/admin#
root@sonic:/home/admin#
root@sonic:/home/admin# show system-health sysready-status detail
System is not ready - one or more services are not up

Service-Name                      Service-Status    App-Ready-Status    Down-Reason    AppStatus-UpdateTime
--------------------------------  ----------------  ------------------  -------------  ----------------------
as7326-56x-pddf-platform-monitor  OK                OK                  -              -
auditd                            OK                OK                  -              -
bgp                               Down              Down                Inactive       -
caclmgrd                          OK                OK                  -              -
config-chassisdb                  OK                OK                  -              -
config-setup                      OK                OK                  -              -
containerd                        OK                OK                  -              -
cron                              OK                OK                  -              -
database                          OK                OK                  -              -
docker                            OK                OK                  -              -
kdump-tools                       OK                OK                  -              -
lldp                              OK                OK                  -              -
mgmt-framework                    OK                OK                  -              -
netfilter-persistent              OK                OK                  -              -
ntp                               OK                OK                  -              -
opennsl-modules                   OK                OK                  -              -
pddf-platform-init                OK                OK                  -              -
pmon                              OK                OK                  -              -
procdockerstatsd                  OK                OK                  -              -
radv                              OK                OK                  -              -
ras-mc-ctl                        OK                OK                  -              -
rsyslog                           OK                OK                  -              -
smartmontools                     OK                OK                  -              -
snmp                              OK                OK                  -              -
ssh                               OK                OK                  -              -
swss                              OK                OK                  -              -
syncd                             OK                OK                  -              -
teamd                             OK                OK                  -              -
telemetry                         OK                OK                  -              -
root@sonic:/home/admin#

root@sonic:/home/admin# systemctl start bgp
root@sonic:/home/admin#
Apr 05 14:50:23.718643 System is ready

root@sonic:/home/admin#
root@sonic:/home/admin#
root@sonic:/home/admin# show system-health sysready-status detail
System is ready

Service-Name                      Service-Status    App-Ready-Status    Down-Reason    AppStatus-UpdateTime
--------------------------------  ----------------  ------------------  -------------  ----------------------
as7326-56x-pddf-platform-monitor  OK                OK                  -              -
auditd                            OK                OK                  -              -
bgp                               OK                OK                  -              -
caclmgrd                          OK                OK                  -              -
config-chassisdb                  OK                OK                  -              -
config-setup                      OK                OK                  -              -
containerd                        OK                OK                  -              -
cron                              OK                OK                  -              -
database                          OK                OK                  -              -
docker                            OK                OK                  -              -
kdump-tools                       OK                OK                  -              -
lldp                              OK                OK                  -              -
mgmt-framework                    OK                OK                  -              -
netfilter-persistent              OK                OK                  -              -
ntp                               OK                OK                  -              -
opennsl-modules                   OK                OK                  -              -
pddf-platform-init                OK                OK                  -              -
pmon                              OK                OK                  -              -
procdockerstatsd                  OK                OK                  -              -
radv                              OK                OK                  -              -
ras-mc-ctl                        OK                OK                  -              -
rsyslog                           OK                OK                  -              -
smartmontools                     OK                OK                  -              -
snmp                              OK                OK                  -              -
ssh                               OK                OK                  -              -
swss                              OK                OK                  -              -
syncd                             OK                OK                  -              -
teamd                             OK                OK                  -              -
telemetry                         OK                OK                  -              -
root@sonic:/home/admin#

@ghost
Copy link

ghost commented Oct 1, 2021

CLA assistant check
All CLA requirements met.

@lgtm-com
Copy link

lgtm-com bot commented Oct 1, 2021

This pull request introduces 1 alert when merging a488880a0b9ed6c8e2b9210b6697519b34a600e0 into 5bdf270 - view on LGTM.com

new alerts:

  • 1 for Unreachable code

@lgtm-com
Copy link

lgtm-com bot commented Oct 4, 2021

This pull request introduces 1 alert when merging 68a3d1fc5a76be11e1189619226cc89e8caf9804 into 5bdf270 - view on LGTM.com

new alerts:

  • 1 for Unreachable code

@lgtm-com
Copy link

lgtm-com bot commented Oct 27, 2021

This pull request introduces 1 alert when merging 201203d4fe7e6962e6cb5e273dff754a14795e27 into f53baac - view on LGTM.com

new alerts:

  • 1 for Unreachable code

@Kalimuthu-Velappan
Copy link
Contributor

retest this please

@venkatmahalingam
Copy link
Contributor

venkatmahalingam commented Nov 2, 2021

Can we please capture all show commands output as well?

@lgtm-com
Copy link

lgtm-com bot commented Nov 5, 2021

This pull request introduces 1 alert when merging 5b9ff62 into efbe1f4 - view on LGTM.com

new alerts:

  • 1 for Unreachable code

@sg893052
Copy link
Contributor Author

sg893052 commented Nov 5, 2021

Can we please capture all show commands output as well?

Have updated "New command output" section with all the show commands output and also attached the UT log file.

system_ready_ut.pdf

Copy link
Collaborator

@liat-grozovik liat-grozovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhangyanzhao please don't merge this PR.
the HLD is now reverted and the other referenced PR should also be reverted until we agree on the HLD approach.

@lgtm-com
Copy link

lgtm-com bot commented Apr 6, 2022

This pull request introduces 5 alerts when merging 434fcf2 into 9e2fbf4 - view on LGTM.com

new alerts:

  • 4 for Unused local variable
  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Apr 25, 2022

This pull request introduces 1 alert when merging 288b748 into d012be9 - view on LGTM.com

new alerts:

  • 1 for Unused import

@sg893052 sg893052 force-pushed the SYSTEM_READY branch 3 times, most recently from f609301 to 7e0529d Compare April 30, 2022 08:07
@lgtm-com
Copy link

lgtm-com bot commented Apr 30, 2022

This pull request introduces 1 alert when merging 7e0529d into fdb79b8 - view on LGTM.com

new alerts:

  • 1 for Unused import

@sg893052 sg893052 force-pushed the SYSTEM_READY branch 2 times, most recently from 9a8efea to 48a468d Compare April 30, 2022 08:43
@lgtm-com
Copy link

lgtm-com bot commented Apr 30, 2022

This pull request introduces 1 alert when merging 48a468d into fdb79b8 - view on LGTM.com

new alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Apr 30, 2022

This pull request introduces 1 alert when merging bdbfe85 into fdb79b8 - view on LGTM.com

new alerts:

  • 1 for Unused import

scripts/sysreadyshow Outdated Show resolved Hide resolved
Copy link

@lizhuhuams lizhuhuams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Senthil Kumar Guruswamy, could you please merge this PR?

@lgtm-com
Copy link

lgtm-com bot commented May 17, 2022

This pull request introduces 1 alert when merging 86e3aea into d7953d2 - view on LGTM.com

new alerts:

  • 1 for Unused import

@sg893052
Copy link
Contributor Author

sg893052 commented May 17, 2022

Senthil Kumar Guruswamy, could you please merge this PR?
Have addressed the new comments and pushed the change. Thanks!

@lgtm-com
Copy link

lgtm-com bot commented May 20, 2022

This pull request introduces 1 alert when merging 350cf66 into 4fc09b1 - view on LGTM.com

new alerts:

  • 1 for Unused import

@sujinmkang sujinmkang merged commit 494dd62 into sonic-net:master May 20, 2022
dprital added a commit to dprital/sonic-buildimage that referenced this pull request May 25, 2022
Update sonic-utilities submodule pointer to include the following:
* [GCU] Handling type1 lists ([sonic-net#2171](sonic-net/sonic-utilities#2171))
* [yang] extend ConfigMgmt constructor to pass YANG options ([sonic-net#2118](sonic-net/sonic-utilities#2118))
* [dump] implement ACL modules ([sonic-net#2153](sonic-net/sonic-utilities#2153))
* show commands for SYSTEM READY ([sonic-net#1851](sonic-net/sonic-utilities#1851))
* [GCU] Handling non-compliant leaf-list with string values ([sonic-net#2174](sonic-net/sonic-utilities#2174))
* Add sonic-delayed.target to Application Extension .timer file generator ([sonic-net#2176](sonic-net/sonic-utilities#2176))
* [portconfig] Allow to configure interface mtu for physical ports ([#l](https://github.com/Azure/sonic-utilities/pull/l))
* Broadcast Unknown-multicast and Unknown-unicast Storm-control  ([sonic-net#928](sonic-net/sonic-utilities#928))
* sonic-utils: initial support for link-training ([sonic-net#2071](sonic-net/sonic-utilities#2071))
* [portchannel] Added ACL/PBH binding checks to the port before getting added to portchannel ([sonic-net#2151](sonic-net/sonic-utilities#2151))
* Modify override testcase to cover PORT admin_status ([sonic-net#2165](sonic-net/sonic-utilities#2165))
* [GCU] Validate peer_group_range ip_range are correct ([sonic-net#2145](sonic-net/sonic-utilities#2145))
* [auto-ts] add memory check ([sonic-net#2116](sonic-net/sonic-utilities#2116))
* support new interface types CR8/SR8/KR8/LR8 which are brougnt by SAI V.1.10.2 ([sonic-net#2167](sonic-net/sonic-utilities#2167))
* [scripts/fast-reboot] Add option to include ssd-upgrader-part boot option with SONiC partition ([sonic-net#2150](sonic-net/sonic-utilities#2150))
* [config reload] Fix invalid rstrip. ([sonic-net#2157](sonic-net/sonic-utilities#2157))
* Accept 0 for queue and dscp ([sonic-net#2162](sonic-net/sonic-utilities#2162))

Signed-off-by: dprital <[email protected]>
@yxieca
Copy link
Contributor

yxieca commented Jul 5, 2022

@sg893052 this change cannot be cherry-picked to 202205 branch cleanly, please create separate PR.

@sg893052
Copy link
Contributor Author

sg893052 commented Jul 6, 2022

this change cannot be cherry-picked to 202205 branch cleanly, please create separate PR.
Could you please elaborate on the conflict ?

@yxieca
Copy link
Contributor

yxieca commented Jul 7, 2022

this change cannot be cherry-picked to 202205 branch cleanly, please create separate PR.
Could you please elaborate on the conflict ?

If you checkout 202205 branch and cherry-pick this change in, you will see the conflict.

sg893052 added a commit to sg893052/sonic-utilities that referenced this pull request Jul 8, 2022
What I did
show command support for System Ready Feature Implementation .
Also sonic-package-manager support for app readiness.

"show system-health sysready-status"
"show system-health sysready-status detail"
"show system-health sysready-status brief"

How I did it
Introduce "show system-health sysready-status" click CLI with options.

How to verify it
Check the click CLIs introduced.
@sg893052
Copy link
Contributor Author

sg893052 commented Jul 8, 2022

@yxieca I have created a new PR post resolving the conflict to be merged to 202205 branch. Thanks!
#2261

yxieca pushed a commit that referenced this pull request Jul 17, 2022
What I did
show command support for System Ready Feature Implementation .
Also sonic-package-manager support for app readiness.

"show system-health sysready-status"
"show system-health sysready-status detail"
"show system-health sysready-status brief"

How I did it
Introduce "show system-health sysready-status" click CLI with options.

How to verify it
Check the click CLIs introduced.
yxieca added a commit that referenced this pull request Jul 22, 2022
yxieca added a commit that referenced this pull request Jul 22, 2022
@Yuval-Mellanox
Copy link

@sg893052 When do you expect to merge it?
if no plans please remove the show cli part from the HLD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants