[show] revert back to swsssdk from swsscommon for ConfigDBConnector() for muxcable #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vaibhav-dahiya <[email protected]>
vdahiya12
changed the title
This is a bit confusing. Can you please make the description more clear? |
updated |
jleveque
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 202012 branch ConfigDBConnector() is imported from swsssdk.
So to use ConfigDBConnector() we still have to import from swsssdk instead of swsscommon.
The https://github.com/Azure/sonic-utilities/pull/1558 changed ConfigDBConnector() to be imported from swsscommon in show/muxcable.py
which causes unit test failure in sonic-utilities.
This PR fixes that.
Signed-off-by: vaibhav-dahiya [email protected]
What I did
changed the import
How I did it
How to verify it
ran a local build to pass unit tests
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)