Fixing serial number read to get from DB if it is populated #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
reviewed
Apr 29, 2021
jleveque
suggested changes
Apr 30, 2021
jleveque
suggested changes
May 3, 2021
jleveque
approved these changes
May 3, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liat-grozovik
approved these changes
May 5, 2021
|
@jleveque would you like this enhancement to be in 202012 as well? if so, please add a label. |
daall
pushed a commit
that referenced
this pull request
May 5, 2021
#### What I did Modified show version command to pick serial number from STATE_DB if it was populated instead of getting it from EEPROM. #### How I did it Check state_db to see if serial number EEPROM section is populated. If yes use the data from DB. If not, read it from the decode-syseeprom
4 tasks
gitsabari
pushed a commit
to gitsabari/sonic-utilities
that referenced
this pull request
Jun 15, 2021
…t#1580) #### What I did Modified show version command to pick serial number from STATE_DB if it was populated instead of getting it from EEPROM. #### How I did it Check state_db to see if serial number EEPROM section is populated. If yes use the data from DB. If not, read it from the decode-syseeprom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Modified show version command to pick serial number from STATE_DB if it was populated instead of getting it from EEPROM.
How I did it
Check state_db to see if serial number EEPROM section is populated. If yes use the data from DB. If not, read it from the decode-syseeprom
How to verify it
Verify running 'show version' with and without pmon running to validate both scenarios, since eepromd in pmon populates the EEPROM table in state_db
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)