No more IP validation as it is more likely a URL #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 000cb47 into e57e7f7 - view on LGTM.com new alerts:
|
isabelmsft
reviewed
Apr 13, 2021
isabelmsft
approved these changes
Apr 16, 2021
renukamanavalan
added a commit
to renukamanavalan/sonic-utilities
that referenced
this pull request
Apr 16, 2021
Dropped IP validation as server takes URL.
daall
pushed a commit
that referenced
this pull request
Apr 29, 2021
Dropped IP validation as server takes URL.
gitsabari
pushed a commit
to gitsabari/sonic-utilities
that referenced
this pull request
Jun 15, 2021
Dropped IP validation as server takes URL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Dropped IP validation as server takes URL.
How I did it
How to verify it
Provide a URL for IP in kube server config command.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)