Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sonic-installer: fix py3 issues in bootloader.aboot #1553

Merged
merged 1 commit into from
Apr 10, 2021

Conversation

Staphylo
Copy link
Contributor

@Staphylo Staphylo commented Apr 9, 2021

These issues are only seen on secureboot enabled platform.

These issues are only seen on secureboot enabled platform.
@Staphylo
Copy link
Contributor Author

Staphylo commented Apr 9, 2021

I believe we also want this change to be cherry-picked on 202012 if sonic-installer runs in python3 there.

@lguohan lguohan merged commit 38f9f60 into sonic-net:master Apr 10, 2021
@daall
Copy link
Contributor

daall commented Apr 13, 2021

@Staphylo there is a merge conflict cherry-picking to 202012 which I guess is probably because we don't have #1366 in 202012. Are those changes needed in the 202012 branch as well?

@Staphylo
Copy link
Contributor Author

Staphylo commented Apr 13, 2021

@dall I do believe we need #1366 in 202012 as well.
Let me run some tests on 202012 and I'll confirm this back to you.

I can alternatively make a change against the 202012 branch that coalesce both changes.
Let me know what you prefer.

@Staphylo
Copy link
Contributor Author

@daall I can confirm that both changes have to be backported.
Let me know if you need my help with anything.

@daall
Copy link
Contributor

daall commented Apr 14, 2021

Thanks for confirming @Staphylo, I will go ahead and cherry-pick both PRs to 202012! I'll let you know if I run into any problems.

daall pushed a commit that referenced this pull request Apr 21, 2021
These issues are only seen on secureboot enabled platform.
gitsabari pushed a commit to gitsabari/sonic-utilities that referenced this pull request Jun 15, 2021
These issues are only seen on secureboot enabled platform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants