Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fast-reboot] Fix fast-reboot-dump.py SonicV2Connector after late merge #1546

Merged
merged 1 commit into from
Apr 5, 2021
Merged

[fast-reboot] Fix fast-reboot-dump.py SonicV2Connector after late merge #1546

merged 1 commit into from
Apr 5, 2021

Conversation

shlomibitton
Copy link
Contributor

Signed-off-by: Shlomi Bitton [email protected]

What I did

This PR #1393 merged after PR: #1392
This caused the first PR to be not aligned with SonicV2Connector change.
This PR motivation is to fix it.

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@qiluo-msft qiluo-msft merged commit 3f2a296 into sonic-net:master Apr 5, 2021
yxieca pushed a commit that referenced this pull request Apr 8, 2021
#### What I did
This PR #1393 merged after PR: #1392
This caused the first PR to be not aligned with SonicV2Connector change.
This PR motivation is to fix it.
liat-grozovik pushed a commit that referenced this pull request Apr 13, 2021
)" (#1561)

- What I did
It seems like this change is not backported to 202012: #1392
So this PR #1546 Is not required on 202012 branch.
It was cherry-picked to 202012 and now the fast-reboot-dump script is broken.

- How I did it
Revert the commit.

- How to verify it
Run fast-reboot on 202012 branch.
gitsabari pushed a commit to gitsabari/sonic-utilities that referenced this pull request Jun 15, 2021
…1546)

#### What I did
This PR sonic-net#1393 merged after PR: sonic-net#1392
This caused the first PR to be not aligned with SonicV2Connector change.
This PR motivation is to fix it.
@shlomibitton shlomibitton deleted the fast_reboot_dump_fix_after_late_merge branch July 27, 2021 16:33
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
5aa80a0f7b27204e7cc23d99ba24ea716f5fb32f (HEAD -> 201911, origin/201911) [logfile]: Add option to specify swss rec file name (sonic-net#1546)

Signed-off-by: Abhishek Dosi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants