-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[config][generic-update] Adding apply-patch, rollback, checkpoints commands #1536
Merged
ghooo
merged 32 commits into
sonic-net:master
from
ghooo:dev/mghoneim/generic_update_rollback
Apr 26, 2021
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
5eaf09e
sekelton
ghooo 8305b67
impl
ghooo 0175885
adding unit-tests and replying to comments
ghooo f251006
restructure files
ghooo 93e0347
fixing compilation errors/warnings
ghooo 2852f9b
fixing lgtm warnings
ghooo 4399fde
fixing compliation errors according to recent yang models
ghooo b9c81b8
using assertCountEqual instead of assertListEqual
ghooo e72407b
catching/raising non-general exceptions
ghooo 30c1265
patch-applier to expect input of ConfigDb patch instead SonicYang patch
ghooo 9aa31df
explaining why sonic_cfggen is loaded as a source
ghooo 0cca529
trying to include sonic_cfggen as a requirement
ghooo b7ed354
back to source loading sonic-cfggen
ghooo 48448af
adding cli commands
ghooo a3ca658
removing dry-run option from checkpoint, delete-checkpoint, list-chec…
ghooo e0d6d43
minor fix
ghooo 99b6796
minor fix
ghooo d42e16f
adding sonic-cfggen to install_requires
ghooo ecd6519
fix generic_config_updater path in test file
ghooo f504980
trying sonic_cfggen instead of sonic-cfggen
ghooo 9e0519d
removing sonic-cfggen from install_requires
ghooo 757d306
make generic_config_updater a pkg
ghooo 038ec67
use generic_config_updater pkg in uts
ghooo cf6be42
removing load_source of sonic-cfggen
ghooo 4a2a964
unifying exceptions
ghooo fc026fb
moving common functionalities to common file
ghooo 90f6731
small fixes
ghooo 34ee074
renaming table without yant to TABLE_WITHOUT_YANG
ghooo 5288345
validate running config before taking a checkpoint
ghooo e5d142c
fixing azure pipeline
ghooo 7ebf3ae
making sonic-config-engine required install_required
ghooo 1a3e37e
err to stderr and format upper case
ghooo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker-sonic-vs
is downloaded then the new sonic-utilities package is installed with most recent modifications. Problem happens if the new package has new external libs or one of the libs is updated as using the commandpip3 install
with--deps
just leave the deps unchanged.I tried different ideas:
pip3 install /wheels/sonic_utilities-1.2-py3-none-any.whl
does not do anything because the package is already installed in the
docker-sonic-vs
pip3 install --force-reinstall /wheels/sonic_utilities-1.2-py3-none-any.whl
does not work because it also forces the deps to be updated but some of the deps such as
sonic-py-common
are not available in public pip repo and are installed with the sonic image indocker-sonic-vs
pip3 install --update /wheels/sonic_utilities-1.2-py3-none-any.whl
does not update sonic-utilities package and only updates its dependencies
The proposed soln achieved the following: