Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax the install_requires, no need to exact version as long as there are no broken changes with future versions #1530

Merged
merged 3 commits into from
May 3, 2021

Conversation

qiluo-msft
Copy link
Contributor

What I did

Fixes sonic-net/sonic-buildimage#7152

How I did it

Relax the install_requires

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@jleveque
Copy link
Contributor

jleveque commented Mar 27, 2021

Two questions:

  1. What about backporting to the 202012 branch?
  2. How can we be certain there are no broken changes with future versions? That was the whole reason for pinning the versions down -- to prevent newer versions getting installed and potentially breaking things.

In reply to: 808638168

@qiluo-msft
Copy link
Contributor Author

  1. I added 'request' label for old branch.
  2. When that happens, we could add new requirement rule to enforce the dependency. On the other hand, pinning down is too conservative, and we need to make sure the host environment or docker already installed the required version, otherwise, there will be upgrade/downgrade, which is confusing.

In reply to: 808638168

setup.py Show resolved Hide resolved
Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I misled you. You can revert your last commit. We cannot bump it up just yet, because it conflicts with the sonic-py-common and sonic-platform-common packages, which still install 6.2.1 because they still support Python 2. Thus, we need to remain back on 6.2.1 for now.

pkg_resources.ContextualVersionConflict: (natsort 7.1.1 (/__w/1/s/.eggs/natsort-7.1.1-py3.7.egg), Requirement.parse('natsort==6.2.1'), {'sonic-py-common', 'sonic-platform-common'})

jleveque
jleveque previously approved these changes Apr 27, 2021
@jleveque
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qiluo-msft qiluo-msft merged commit 9120766 into sonic-net:master May 3, 2021
@qiluo-msft qiluo-msft deleted the qiluo/relaxdep branch May 3, 2021 16:03
qiluo-msft added a commit to qiluo-msft/sonic-utilities that referenced this pull request May 5, 2021
… are no broken changes with future versions (sonic-net#1530)

Fixes sonic-net/sonic-buildimage#7152

Relax the install_requires
qiluo-msft added a commit that referenced this pull request May 5, 2021
… are no broken changes with future versions (#1530) (#1592)

Same as #1530
But for 202012 branch

Fix a previous merge/cherry-pick mistake: deepdiff should be a tests_require
gitsabari pushed a commit to gitsabari/sonic-utilities that referenced this pull request Jun 15, 2021
… are no broken changes with future versions (sonic-net#1530)

#### What I did
Fixes sonic-net/sonic-buildimage#7152

#### How I did it
Relax the install_requires
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants