Stop PMON docker before cold and soft reboots #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jleveque Please review this PR. |
jleveque
reviewed
Mar 18, 2021
scripts/reboot
Outdated
| @@ -178,6 +190,8 @@ if [ -x ${DEVPATH}/${PLATFORM}/${PLATFORM_UPDATE_REBOOT_CAUSE} ]; then | |||
| ${DEVPATH}/${PLATFORM}/${PLATFORM_UPDATE_REBOOT_CAUSE} | |||
| fi | |||
|
|
|||
| stop_pmon_service | |||
There was a problem hiding this comment.
I understand you want to stop this at the last possible moment, but does it just make things simpler to add the logic to the existing stop_sonic_services() function?
There was a problem hiding this comment.
If there is any platform API is introduced/invoked in between, it will fail as PMON is shutdown early.
There was a problem hiding this comment.
I don't see a problem moving stop_sonic_service to here.
There was a problem hiding this comment.
@aravindthoram can we consolidate the change in stop_sonic_services and move the call to there?
There was a problem hiding this comment.
@yxieca I'll commit the new changes soon.
jleveque
suggested changes
Mar 18, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
reviewed
Apr 12, 2021
aravindmani-1
force-pushed
the
Stop_PMon_in_coldboot
branch
from
b4d9b1e
to
d8b7108
Compare
…o Stop_PMon_in_coldboot
…i-1/sonic-utilities into Stop_PMon_in_coldboot
|
@yxieca Addressed the comments. |
yxieca
approved these changes
Apr 12, 2021
jleveque
approved these changes
Apr 12, 2021
jleveque
changed the title
daall
pushed a commit
that referenced
this pull request
Apr 21, 2021
Prevent potential kernel oops if drivers are removed/devices are deinitialized while PMon daemons are still trying to access those devices.
gitsabari
pushed a commit
to gitsabari/sonic-utilities
that referenced
this pull request
Jun 15, 2021
Prevent potential kernel oops if drivers are removed/devices are deinitialized while PMon daemons are still trying to access those devices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Prevent potential kernel oops if drivers are removed/devices are deinitialized while PMon daemons are still trying to access those devices.
How I did it
Edit reboot script and stop pmon docker and services
How to verify it
Check docker ps output just before cold boot is being executed.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
UT:
cold_boot_UT.txt