[show][config] fix show mux status health field; add support for hwmode functionality to toggle mux, check mux direction for Y cable (#1467) #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de functionality to toggle mux, check mux direction for Y cable (sonic-net#1467) This PR fixes the show mux status "health" field. There is also support for new commands for muxcable show muxcable hwmode muxdirection sudo config muxcable hwmode state active all which can check the muxdirection and toggle the mux direction directly through eeprom What I did Fixed the show mux status health field Also added these new commands vdahiya@BN9-0101-0301-01UT0:~$ show muxcable hwmode muxdirection Port Direction ----------- ----------- Ethernet0 active Ethernet4 active Ethernet8 active Ethernet12 active Ethernet16 active vdahiya@BN9-0101-0301-01UT0:~$ sudo config muxcable hwmode state active all Muxcables at all ports will be changed to active state. Continue? [y/N]: y Success in toggling port Ethernet0 to active Success in toggling port Ethernet4 to active Success in toggling port Ethernet8 to active Success in toggling port Ethernet12 to active Success in toggling port Ethernet16 to active Signed-off-by: vaibhav-dahiya <[email protected]>
tahmed-dev
approved these changes
Mar 11, 2021
Signed-off-by: vaibhav-dahiya <[email protected]>
daall
reviewed
Mar 11, 2021
show/muxcable.py
Outdated
| namespaces = multi_asic.get_front_end_namespaces() | ||
| for namespace in namespaces: | ||
| asic_id = multi_asic.get_asic_index_from_namespace(namespace) | ||
| per_npu_statedb[asic_id] = SonicV2Connector(use_unix_socket_path=False, namespace=namespace) |
There was a problem hiding this comment.
The unit tests are failing b/c this part is different b/w the master and 202012 branches
Suggested change
| per_npu_statedb[asic_id] = SonicV2Connector(use_unix_socket_path=False, namespace=namespace) | |
| per_npu_statedb[asic_id] = swsscommon.SonicV2Connector(use_unix_socket_path=False, namespace=namespace) |
There was a problem hiding this comment.
@daall there are still some config_breakout failures.
There was a problem hiding this comment.
they are unrelated, it seems like there is some general issue with the check-build setup for 202012 in utilities. I can open a dummy PR later to debug this further, this change is OK
Signed-off-by: vaibhav-dahiya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the show mux status "health" field.
There is also support for new commands for muxcable
show muxcable hwmode muxdirection
sudo config muxcable hwmode state active all
which can check the muxdirection and toggle the mux direction directly through eeprom
What I did
Fixed the show mux status health field
Also added these new commands
How I did it
Added the changes to show/muxcable.py to correctly retrieve health "state" field from the "MUX_LINKMGR_TABLE" state DB table.
For new cli commands added the support in show/muxcable.py and config/muxcable.py
How to verify it
Ran the command on the 7050 testbed
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
Signed-off-by: vaibhav-dahiya [email protected]