[201911][acl-loader] Add support for matching on ICMP and VLAN info #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ICMP and VLAN fields
- Add new unit test cases
Signed-off-by: Danny Allen <[email protected]>
qiluo-msft
approved these changes
Mar 3, 2021
|
retest this please |
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
- [201911][acl] Expand VLAN into VLAN members when creating an ACL table (sonic-net#1477) - [201911][acl-loader] Add support for matching on ICMP and VLAN info (sonic-net#1476) - [201911][acl-loader] Improve input validation for acl_loader (sonic-net#1481) Signed-off-by: Danny Allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Ported #1469 to 201911.
How I did it
Moved files from
teststosonic-utilities-tests.How to verify it
Run unit tests + run ACL tests against 201911 image with this change and verify there is no regression.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)