-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified the tests to use mock functionality of get_child_port function under portconfig utility #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samaity
force-pushed
the
mock_test_child_port
branch
2 times, most recently
from
February 25, 2021 15:22
523cabb
to
5598a1c
Compare
samaity
force-pushed
the
mock_test_child_port
branch
8 times, most recently
from
March 9, 2021 21:01
9a77f0b
to
1f7cf5c
Compare
…on under portconfig utility Signed-off-by: Sangita Maity <[email protected]>
samaity
force-pushed
the
mock_test_child_port
branch
from
March 9, 2021 22:20
1f7cf5c
to
52fef5d
Compare
zhenggen-xu
reviewed
Mar 11, 2021
Signed-off-by: Sangita Maity <[email protected]>
retest this please |
@jleveque -- Kindly review whenever possible. need help in merging the code. Thanks! |
jleveque
suggested changes
Mar 23, 2021
Signed-off-by: Sangita Maity <[email protected]>
jleveque
approved these changes
Mar 24, 2021
Thanks, @jleveque !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sangita Maity [email protected]
What I did
Modified the tests to use mock functionality of get_child_port function under portconfig utility. This will remove the dependency of port config utility in the sonic-buildimage and make the test case more robust specific to the DPB cli utility.
How I did it
used MagicMock feature
How to verify it
All test cases are passed in config_dpb_test.py file