Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropped redundant code. #1463

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Conversation

renukamanavalan
Copy link
Contributor

What I did

Removed code that had bug, because it is redundant

How I did it

The key used is as read from APPL-DB, hence use it as such to get the value,
to help get the interface name, so it can be used for filtering out.

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

The key used is as read from APPL-DB, hence use it as such to get the value,
to help get the interfce name, so it can be used for filtering out.
Copy link
Contributor

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. May be wait for other reviewers.

@lguohan lguohan merged commit e74de6a into sonic-net:master Feb 25, 2021
anand-kumar-subramanian pushed a commit to anand-kumar-subramanian/sonic-utilities that referenced this pull request Mar 2, 2021
The key used is as read from APPL-DB, hence use it as such to get the value,
to help get the interfce name, so it can be used for filtering out.
yxieca pushed a commit that referenced this pull request Mar 3, 2021
The key used is as read from APPL-DB, hence use it as such to get the value,
to help get the interfce name, so it can be used for filtering out.
abdosi pushed a commit that referenced this pull request Mar 17, 2021
The key used is as read from APPL-DB, hence use it as such to get the value,
to help get the interfce name, so it can be used for filtering out.
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
ad8eb74 (HEAD -> 201911, origin/201911)
[route_check]: Dropped redundant code. (sonic-net#1463)

Signed-off-by: Abhishek Dosi <[email protected]>
@renukamanavalan renukamanavalan deleted the rt_chk_fix branch September 16, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants