[reboot] Add platform-specific reboot cause update hook #1454
Conversation
|
@rkdevi27, @padmanarayana: This should only be cherry-picked into 202012, not 201911 or 201811, correct? |
|
@jleveque For now it can be cherry picked to 202012 branch. But we need these to be cherry picked into 201811 and 201911 branches once we raise separate pull request (similar to sonic-net/sonic-buildimage#6835 ) for 201811 and 201911 branches. |
I see, thanks. For now I will add the "Request for 202012 branch" label. When you open the sonic-buildimage PRs for 201811 and 201911, please be sure to add a reminder that this PR will need to be cherry-picked to those branches at those times. Actually, it appears that this PR will not cause harm if cherry-picked into those branches now. However, if there is a chance it will not be needed in those branches, I would rather wait until we know for sure. |
Sure, Thanks |
|
@rkdevi27: Can you please update the PR description? It refers to the change in sonic-buildimage, but doesn't really reflect this change. |
rkdevi27
changed the title
jleveque
changed the title
#### What I did The S6000 devices, the cold reboot is abrupt and it is likely to cause issues which will cause the device to land into EFI shell. Hence the platform reboot will happen after graceful unmount of all the filesystems as in S6100. #### How I did it In reboot script, if platform-specific reboot cause update script exists, run it
#### What I did The S6000 devices, the cold reboot is abrupt and it is likely to cause issues which will cause the device to land into EFI shell. Hence the platform reboot will happen after graceful unmount of all the filesystems as in S6100. #### How I did it In reboot script, if platform-specific reboot cause update script exists, run it
|
@rkdevi27 do you mind open an PR to port this change to 201811 branch. This PR cannot be cherry-picked cleanly. |
Sure. I will raise a separate PR for 201811 branch. |
What I did The S6000 devices, the cold reboot is abrupt and it is likely to cause issues which will cause the device to land into EFI shell. Hence the platform reboot will happen after graceful unmount of all the filesystems as in S6100. This has been merged in master through #1454 and raising it separately since it can't be cherry picked cleanly. It is related to sonic-buildimage PR sonic-net/sonic-buildimage#6923 How I did it In reboot script, if platform-specific reboot cause update script exists, run it How to verify it Issue "reboot" command to verify if the reboot is happening gracefully. UT_logs_201811.txt
What I did
The S6000 devices, the cold reboot is abrupt and it is likely to cause issues which will cause the device to land into EFI shell. Hence the platform reboot will happen after graceful unmount of all the filesystems as in S6100.
How I did it
In reboot script, if platform-specific reboot cause update script exists, run it
How to verify it
Issue "reboot" command to verify if the reboot is happening gracefully.
UT_logs.txt
These changes are associated with sonic-net/sonic-buildimage#6835.
Please cherry pick the changes to 201811, 201911 branches
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)