[show] cli support for show muxcable cableinfo #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vaibhav-dahiya <[email protected]>
Signed-off-by: vaibhav-dahiya <[email protected]>
jleveque
suggested changes
Feb 22, 2021
Signed-off-by: vaibhav-dahiya <[email protected]>
Signed-off-by: vaibhav-dahiya <[email protected]>
jleveque
suggested changes
Feb 22, 2021
Signed-off-by: vaibhav-dahiya <[email protected]>
jleveque
suggested changes
Feb 25, 2021
jleveque
suggested changes
Feb 25, 2021
show/muxcable.py
Outdated
| temp_list.append(part) | ||
| lane_data.append(temp_list) | ||
| click.echo(tabulate(lane_data, headers=headers)) | ||
| sys.exit(EXIT_SUCCESS) |
There was a problem hiding this comment.
Now that we've changed the success code to 0, there's no need to call sys.exit(EXIT_SUCCESS) anywhere, because Click will exit 0 by default.
There was a problem hiding this comment.
Please plan to open a cleanup PR to remove all other sys.exit(EXIT_SUCCESS) calls
Signed-off-by: vaibhav-dahiya <[email protected]>
Signed-off-by: vaibhav-dahiya <[email protected]>
jleveque
approved these changes
Feb 25, 2021
|
Retest this please |
anand-kumar-subramanian
pushed a commit
to anand-kumar-subramanian/sonic-utilities
that referenced
this pull request
Mar 2, 2021
Summary: This PR provides the support for adding CLI commands for retrieving cable vendor name and part number information of the muxcable. In particular these Cli commands are supported: show muxcable cableinfo <port> Approach added the changes in sonic-utilities/show and sonic-utilities/config by changing the muxcable.py What is the motivation for this PR? To add the support for Cli for muxcable to be utilized for retrieving cable vendor name and part number information of the muxcable. Signed-off-by: vaibhav-dahiya <[email protected]>
daall
pushed a commit
that referenced
this pull request
Mar 10, 2021
Summary: This PR provides the support for adding CLI commands for retrieving cable vendor name and part number information of the muxcable. In particular these Cli commands are supported: show muxcable cableinfo <port> Approach added the changes in sonic-utilities/show and sonic-utilities/config by changing the muxcable.py What is the motivation for this PR? To add the support for Cli for muxcable to be utilized for retrieving cable vendor name and part number information of the muxcable. Signed-off-by: vaibhav-dahiya <[email protected]>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
[portsorch]: Set proper initial forwarding state for LAG member (sonic-net#1448) Signed-off-by: Abhishek Dosi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR provides the support for adding CLI commands for retrieving cable vendor name and part number information of the muxcable.
In particular these Cli commands are supported:
show muxcable cableinfo <port>Type of change
Approach
added the changes in sonic-utilities/show and sonic-utilities/config by changing the muxcable.py
What is the motivation for this PR?
To add the support for Cli for muxcable to be utilized for retrieving cable vendor name and part number information of the muxcable.
How did you do it?
Added the changes inside sonic-utilities and tested it on the testbed
How did you verify/test it?
Ran the cli commands on an Arista7050cx3 testbed with Gemini cable
Signed-off-by: vaibhav-dahiya [email protected]