Fix: initialize SonicDBConfig differently for single or multi_asic (continued) #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
previously approved these changes
Feb 10, 2021
jleveque
previously approved these changes
Feb 10, 2021
judyjoseph
reviewed
Feb 10, 2021
judyjoseph
reviewed
Feb 10, 2021
qiluo-msft
force-pushed
the
qiluo/globaldbinit
branch
from
3a3836c
to
a8bc54a
Compare
lguohan
approved these changes
Feb 11, 2021
4 tasks
judyjoseph
reviewed
Feb 11, 2021
| @@ -211,15 +211,20 @@ def cli(ctx): | |||
| # Use the db object if given as input. | |||
| db = None if ctx.obj is None else ctx.obj.cfgdb | |||
|
|
|||
| # Note: SonicDBConfig may be already initialized in unit test, then skip | |||
| if not SonicDBConfig.isInit(): | |||
There was a problem hiding this comment.
isInit() is the check for SonicDBConfig.initialize(), ideal place would be in else: before we call initialize().
judyjoseph
approved these changes
Feb 11, 2021
anand-kumar-subramanian
pushed a commit
to anand-kumar-subramanian/sonic-utilities
that referenced
this pull request
Mar 2, 2021
…ontinued) (sonic-net#1417) **- What I did** This bug is exposed by sonic-net#1392. Previously the `config` command will call `SonicDBConfig.load_sonic_global_db_config()` even on a single ASIC platform, and it will silently failed. After exposed, it will fail with error syslog message: ``` Feb 9 05:04:46.462361 vlab-01 ERR python3: :- initializeGlobalConfig: Sonic database config global file doesn't exist at /var/run/redis/sonic-db/database_global.json ``` **- How to verify it** Unit test and test in DUT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
This bug is exposed by #1392. Previously the
configcommand will callSonicDBConfig.load_sonic_global_db_config()even on a single ASIC platform, and it will silently failed. After exposed, it will fail with error syslog message:- How I did it
- How to verify it
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)