[show] [lldp] Fix error 'the input device is not a TTY' when running 'show lldp table/neighbor' #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ugh SSH command. The command 'show lldp table/neighbor' always return error message 'the input device is not a TTY' when running in a SSH command or running with Ansible. This commit is to fix this issue.
lguohan
approved these changes
Aug 24, 2020
|
i think there is another one on the master for the same fix. |
Yes. I just saw that. So do we need to merge this PR on branch 201911? |
|
It looks like the affected statement was broken into two lines in the 201911 branch, so the master PR might not cherry-pick cleanly. We can merge this PR to 201911. |
|
I updated the PR description to add the note, "This is a backport of #1016 to the 201911 branch." |
jleveque
approved these changes
Aug 24, 2020
|
Retest this please |
1 similar comment
|
Retest this please |
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
Fix error when running 'show lldp table' or 'show lldp neighbor' through SSH command. (sonic-net#1067) [201911]: Multi asic show interface support (sonic-net#1070) [counterpoll] Add new FC group for port buffer drop counters (sonic-net#1024) [201911] show interface portchannel support for Multi ASIC (sonic-net#1071) Fix a typo in mellanox_buffer_migrator (sonic-net#1090) Fix pfcwd stats crash with invalid queue name (sonic-net#1077) [PFCWD] Fix issue with "pfcwd show stats" command during SONiC init (sonic-net#1018) enable watchdog before running platform specific reboot plugin (sonic-net#1037) Add namespace of the process in the coredump filename. (sonic-net#1091)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
This PR is to fix sonic-net/sonic-buildimage#5239
The command 'show lldp table/neighbor' always return error message 'the input device is not a TTY' when running in a SSH command or running with Ansible. This commit is to fix this issue.
This is a backport of #1016 to the 201911 branch.
- How I did it
Update lldpshow. Replace the -it in docker exec with -i, because there is no need for a pseudo-TTY when running in command line.
- How to verify it
Verify on Arista-7260.
Before update:
After Update:
- Previous command output (if the output of a command-line utility has changed)
N/A
- New command output (if the output of a command-line utility has changed)
N/A