Some minor refactoring in collect_cisco_8000

Signed-off-by: Geert Vlaemynck <[email protected]>
sonic-net · Sep 7, 2023 · b6569bf · b6569bf
1 parent b729e6c
commit b6569bf
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/scripts/generate_dump b/scripts/generate_dump
@@ -1276,11 +1276,11 @@ collect_cisco_8000() {
 
     # run 'hw-management-generate-dump.sh' script and save the result file
     HW_DUMP_FILE=/usr/bin/hw-management-generate-dump.sh
-    if [ -f "$HW_DUMP_FILE" ]; then
-      ${CMD_PREFIX} /usr/bin/hw-management-generate-dump.sh $ALLOW_PROCESS_STOP
+    if [[ -x $HW_DUMP_FILE ]]; then
+      ${CMD_PREFIX} $HW_DUMP_FILE $ALLOW_PROCESS_STOP
       ret=$?
-      if [ $ret -ne 0 ]; then
-        if [ $ret -eq $TIMEOUT_EXIT_CODE ]; then
+      if [[ $ret -ne 0 ]]; then
+        if [[ $ret -eq $TIMEOUT_EXIT_CODE ]]; then
           echo "hw-management dump timedout after ${TIMEOUT_MIN} minutes."
         else
           echo "hw-management dump failed ..."