resolve comment

sonic-net · Feb 28, 2024 · 046079e · 046079e
1 parent 7a4e3c3
commit 046079e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/config/main.py b/config/main.py
@@ -2010,11 +2010,11 @@ def aaa_table_hard_dependency_check(config_json):
     AAA_TABLE = config_json.get("AAA", {})
     TACPLUS_TABLE = config_json.get("TACPLUS", {})
 
-    aaa_authorization_login = AAA_TABLE.get("authorization", {}).get("login", "")
-    tacacs_enable = "tacacs+" in aaa_authorization_login.split(",")
+    aaa_authentication_login = AAA_TABLE.get("authentication", {}).get("login", "")
+    tacacs_enable = "tacacs+" in aaa_authentication_login.split(",")
     tacplus_passkey = TACPLUS_TABLE.get("global", {}).get("passkey", "")
     if tacacs_enable and len(tacplus_passkey) == 0:
-        click.secho("Authorization with 'tacacs+' is not allowed when passkey not exits.", fg="magenta")
+        click.secho("Authentication with 'tacacs+' is not allowed when passkey not exits.", fg="magenta")
         sys.exit(1)
 
 

diff --git a/tests/config_override_input/aaa_yang_hard_check.json b/tests/config_override_input/aaa_yang_hard_check.json
@@ -1,7 +1,7 @@
 {
     "running_config": {
         "AAA": {
-            "authorization": {
+            "authentication": {
                 "login": "tacacs+"
             }
         },
@@ -15,7 +15,7 @@
     },
     "expected_config": {
         "AAA": {
-            "authorization": {
+            "authentication": {
                 "login": "tacacs+"
             }
         },

diff --git a/tests/config_override_test.py b/tests/config_override_test.py
@@ -177,7 +177,7 @@ def read_json_file_side_effect(filename):
                                        ['golden_config_db.json'], obj=db)
 
                 assert result.exit_code != 0
-                assert "Authorization with 'tacacs+' is not allowed when passkey not exits." in result.output
+                assert "Authentication with 'tacacs+' is not allowed when passkey not exits." in result.output
 
     def check_override_config_table(self, db, config, running_config,
                                     golden_config, expected_config):