ARM32 bit fixes, for 64bit printf format specifier #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antony Rheneus <[email protected]>
Signed-off-by: Antony Rheneus <[email protected]>
jleveque
approved these changes
Jul 23, 2019
stcheng
approved these changes
Jul 23, 2019
Signed-off-by: Antony Rheneus <[email protected]>
|
Need help in restarting the vs build, as it went into build failure as below. |
|
retest this please |
3 similar comments
|
retest this please |
|
retest this please |
|
retest this please |
tonytitus
pushed a commit
to tonytitus/sonic-swss
that referenced
this pull request
Jul 31, 2019
* ARM32 bit fixes, for 64bit printf format specifier Signed-off-by: Antony Rheneus <[email protected]>
qiluo-msft
reviewed
Aug 2, 2019
| if (portCount != keys.size() - 2) | ||
| { | ||
| // Invalid port table | ||
| SWSS_LOG_ERROR("Invalid port table: portCount, expecting %lu, got %lu", |
There was a problem hiding this comment.
%lu, got %lu" [](start = 65, length = 13)
The original format strings are correct. Please change back.
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
- What I did Add support for QSFP-DD cables on 'sfpshow' script Adapt sfp_test to new eeprom output. - How I did it Added a new label "application_advertisement" to print from DB. Exclude "specification compliance" print from QSFP-DD cables. Signed-off-by: Shlomi Bitton <[email protected]>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
…-net#989) What/Why I did: Added Support for enum query capability of Nexthop Group Type. This is needed for DVS testing of Ordered ECMP Feature. Design Doc: sonic-net/SONiC#896
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antony Rheneus [email protected]
What I did
Why I did it
How I verified it
Details if related