[vlan] Add pytest cases to validate the behavior about add LAG member to vlan. #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlan. Signed-off-by: Emma Lin <[email protected]>
|
retest this please |
Signed-off-by: Emma Lin <[email protected]>
linemma
force-pushed
the
add_tests_lag_member
branch
from
81352f0
to
487608e
Compare
|
@linemma , can you resolve the conflict? |
|
@lguohan, resolved, please review again. Thanks. |
|
retest this please |
|
need to resolve the conflict again due to previous vlan test contribution from you. |
|
@lguohan, resolved, please review again. Thanks! |
|
retest this please |
3 similar comments
|
retest this please |
|
retest this please |
|
retest this please |
stcheng
approved these changes
Aug 5, 2019
|
retest this please |
1 similar comment
|
retest this please |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Signed-off-by: Guohan Lu <[email protected]>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
…the MACsec port was disabled in runtime (sonic-net#875) * Add MACsec filter state guard Signed-off-by: Ze Gan <[email protected]> * Add volatile qualifer for state Signed-off-by: Ze Gan <[email protected]> * Polish code format Signed-off-by: Ze Gan <[email protected]> * Fix the macsec device was shutdown by ouutside Signed-off-by: Ze Gan <[email protected]> * fix typo Signed-off-by: Ze Gan <[email protected]> * Remove overkill qualifier Signed-off-by: Ze Gan <[email protected]> * fix typo Signed-off-by: Ze Gan <[email protected]> * Fix spell warning Signed-off-by: Ze Gan <[email protected]> * Fix bug Signed-off-by: Ze Gan <[email protected]> * Format code Signed-off-by: Ze Gan <[email protected]> * Fix unittest Signed-off-by: Ze Gan <[email protected]> * Add unittest for State guard Signed-off-by: Ze Gan <[email protected]> * Update Makefile.am for testing MACsec Filter State Guard Signed-off-by: Ze Gan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
[vlan] Add pytest cases to validate the behavior about add LAG member to vlan.
Why I did it
How I verified it
Add test case:
Details if related
==================================================================== test session starts =====================================================================
platform linux2 -- Python 2.7.15rc1, pytest-3.3.0, py-1.8.0, pluggy-0.6.0 -- /usr/bin/python
cachedir: .cache
rootdir: /home/ubuntu/sonic-buildimage/src/sonic-swss/tests, inifile:
collected 11 items
test_vlan.py::TestVlan::test_VlanAddRemove PASSED [ 9%]
test_vlan.py::TestVlan::test_MultipleVlan PASSED [ 18%]
test_vlan.py::TestVlan::test_AddVlanWithIncorrectKeyPrefix[test_input0-0] PASSED [ 27%]
test_vlan.py::TestVlan::test_AddVlanWithIncorrectKeyPrefix[test_input1-0] PASSED [ 36%]
test_vlan.py::TestVlan::test_AddVlanWithIncorrectKeyPrefix[test_input2-0] PASSED [ 45%]
test_vlan.py::TestVlan::test_AddVlanWithIncorrectKeyPrefix[test_input3-1] PASSED [ 54%]
test_vlan.py::TestVlan::test_AddVlanWithIncorrectValueType[test_input0-0] PASSED [ 63%]
test_vlan.py::TestVlan::test_AddVlanWithIncorrectValueType[test_input1-0] PASSED [ 72%]
test_vlan.py::TestVlan::test_AddVlanWithIncorrectValueType[test_input2-0] PASSED [ 81%]
test_vlan.py::TestVlan::test_AddVlanWithIncorrectValueType[test_input3-1] PASSED [ 90%]
test_vlan.py::TestVlan::test_AddPortChannelToVlan PASSED [100%]
================================================================= 11 passed in 62.15 seconds =================================================================
Signed-off-by: Emma Lin [email protected]