[Aclorch] hard code table name separator to make it compatible with 201803 branch #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge from Azure/sonic-swss master
|
Not against master, it should be a quick bug fix for 201803 branch. |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
* [scripts] remove duplicate script copying for nbrshow Signed-off-by: Ying Xie <[email protected]> * also fix mmuconfig location to make the list in alphabetic order
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Hard code the table name separator with a Macro instead of getting it by calling swss-common functions.
Why I did it
On the 201803 branch, the swss-common submodule have an issue when the table obeject constructed without a table separator, to make the fix #sonic-net/sonic-buildimage#1712 also work on the branch, change it.
How I verified it
Run ACL/Everflow/CRM test.
Details if related
If decided to update the swss-common submodule on the branch, then this PR not needed anymore.