[tests] Attempt to fix compatibility break from SAI headers #3321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcudnik
requested review from
prgeor,
qiluo-msft and
lguohan
and removed request for
prsunny
|
/azp run |
|
Commenter does not have sufficient privileges for PR 3321 in repo sonic-net/sonic-swss |
|
Can we merge this ? I need this change to advance sairedis sai submodule |
lguohan
approved these changes
Oct 14, 2024
|
can you merge this ? i dont heve permissions to merge |
prgeor
approved these changes
Oct 15, 2024
|
@lguohan @prgeor @qiluo-msft can we merge this ? this is blocking |
stepanblyschak
pushed a commit
to stepanblyschak/sonic-swss
that referenced
this pull request
Nov 13, 2024
…t#3321) Error is show up when we move sai headers from v1.14 to v1.15 sonic-net/sonic-sairedis#1431 (comment) What I did Fix tests so they can pass during backward compatibility break
divyachandralekha
pushed a commit
to divyachandralekha/sonic-swss
that referenced
this pull request
Dec 12, 2024
…t#3321) Error is show up when we move sai headers from v1.14 to v1.15 sonic-net/sonic-sairedis#1431 (comment) What I did Fix tests so they can pass during backward compatibility break
divyachandralekha
pushed a commit
to divyachandralekha/sonic-swss
that referenced
this pull request
Dec 12, 2024
…t#3321) Error is show up when we move sai headers from v1.14 to v1.15 sonic-net/sonic-sairedis#1431 (comment) What I did Fix tests so they can pass during backward compatibility break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error is show up when we move sai headers from v1.14 to v1.15
sonic-net/sonic-sairedis#1431 (comment)
What I did
Fix tests so they can pass during backward compatibility break
Why I did it
because of breaking change in SAI headers, g++ requires all struct fields to be populated:
How I verified it
Local build
Details if related