[dash]: Wait for routing type config when adding VNET mapping #3312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]>
theasianpianist
requested review from
prabhataravind,
Pterosaur and
prsunny
and removed request for
prsunny
r12f
approved these changes
Oct 1, 2024
Signed-off-by: Lawrence Lee <[email protected]>
prsunny
approved these changes
Oct 11, 2024
stepanblyschak
pushed a commit
to stepanblyschak/sonic-swss
that referenced
this pull request
Nov 13, 2024
…net#3312) What I did Block adding VNET mapping until the routing type for that VNET mapping has been configured Perform setup/teardown of DASH route group tests on a per-testcase basis instead of per-module.
divyachandralekha
pushed a commit
to divyachandralekha/sonic-swss
that referenced
this pull request
Dec 12, 2024
…net#3312) What I did Block adding VNET mapping until the routing type for that VNET mapping has been configured Perform setup/teardown of DASH route group tests on a per-testcase basis instead of per-module.
divyachandralekha
pushed a commit
to divyachandralekha/sonic-swss
that referenced
this pull request
Dec 12, 2024
…net#3312) What I did Block adding VNET mapping until the routing type for that VNET mapping has been configured Perform setup/teardown of DASH route group tests on a per-testcase basis instead of per-module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Why I did it
How I verified it
Details if related