Add mgmt VRF support. #3299
Add mgmt VRF support. #3299
Conversation
|
This PR depends on sonic-net/sonic-swss-common#920 merge first. |
|
/azpw run Azure.sonic-swss |
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-swss |
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-swss |
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| case 'v': | ||
| if (optarg) | ||
| { | ||
| vrf = optarg; |
There was a problem hiding this comment.
How is it used? #Closed
There was a problem hiding this comment.
When mgmt VRF feature enabled, orchagent need start with "-v mgmt" parameter. "mgmt" is the VRF name.
Here is the code change:
sonic-net/sonic-buildimage#20345
There was a problem hiding this comment.
This part of code can't cover by VS test because VS test does not enable VRF.
There already VRF test case failed in sonic-mgmt, and will fix by this PR.
There was a problem hiding this comment.
Will add a test case for code coverage
|
/azpw run Azure.sonic-swss |
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
This PR looks good to me, but I'm not sure whether there is a same issue on the Redis channel. Should we have an ADO for tracking it?
@prsunny @qiluo-msft
|
/azpw run Azure.sonic-swss |
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-swss |
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-swss |
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Add mgmt VRF support. #### Why I did it Fix following issue: sonic-net/sonic-buildimage#19638 ### How I did it Add VRF parameter and bind ZMQ to VRF. #### How to verify it Pass all UT. Manually verify issue fixed. ### Description for the changelog Add mgmt VRF support.
Add mgmt VRF support. #### Why I did it Fix following issue: sonic-net/sonic-buildimage#19638 ### How I did it Add VRF parameter and bind ZMQ to VRF. #### How to verify it Pass all UT. Manually verify issue fixed. ### Description for the changelog Add mgmt VRF support.
Add mgmt VRF support. #### Why I did it Fix following issue: sonic-net/sonic-buildimage#19638 ### How I did it Add VRF parameter and bind ZMQ to VRF. #### How to verify it Pass all UT. Manually verify issue fixed. ### Description for the changelog Add mgmt VRF support.
Add mgmt VRF support.
Why I did it
Fix following issue:
sonic-net/sonic-buildimage#19638
Work item tracking
How I did it
Add VRF parameter and bind ZMQ to VRF.
How to verify it
Pass all UT.
Manually verify issue fixed.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Add mgmt VRF support.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)