[DASH] Remove deprecated 'action_type' refs #3257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lawrence Lee <[email protected]>
theasianpianist
requested review from
prabhataravind and
prsunny
and removed request for
prsunny
Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]>
Signed-off-by: Lawrence Lee <[email protected]>
theasianpianist
force-pushed
the
deprecate-action-type
branch
from
40e7b2f to
907d9c8
Compare
prabhataravind
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
For DASH_ROUTE_TABLE entries, change
action_typereferences torouting_typereferences.Why I did it
sonic-net/sonic-dash-api#20 deprecates
action_typein DASH_ROUTE_TABLE in favor ofrouting_typeto more accurately describe the field.Any downstream repositories which build SWSS will see a deprecation warning for
action_typeand builds with-Werrorset will not compile.How I verified it
Details if related