Add a check if OID exists before setting Host Tx Ready Signal Enable #3232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prgeor |
Junchao-Mellanox
approved these changes
Jul 11, 2024
|
@noaOrMlnx Why OA is acting upon deleted ports? |
prsunny
pushed a commit
that referenced
this pull request
Jul 12, 2024
This is a cherry-pick of #3232 What I did I added a query before setting host tx ready - must check that Oid exists before setting attribute to SAI.
|
@prgeor , can you please approve? |
|
@prgeor OA is acting upon port deletion, if a module was plugged out, and its entry was deleted from TRANSCEIVER_INFO table is State DB, so it could set HostTxReady enable to false. |
prgeor
reviewed
Jul 18, 2024
| } | ||
|
|
||
| SWSS_LOG_NOTICE("Could not set SAI_PORT_ATTR_HOST_TX_SIGNAL_ENABLE - OID does not exist 0x%" PRIx64, port.m_port_id); |
There was a problem hiding this comment.
@noaOrMlnx can we print the port name in the notice message?
prgeor
approved these changes
Jul 18, 2024
|
Please fix the conflict to 202311 branch. |
mssonicbld
pushed a commit
to mssonicbld/sonic-swss
that referenced
this pull request
Jul 25, 2024
…onic-net#3232) - What I did I added a query before setting host tx ready - must check that Oid exists before setting attribute to SAI. - Why I did it When we do dynamic port breakout to a Fw-control port, portsorch receives a notification that something was deleted in TRANSCEIVER_INFO table from State DB, and tries to set HOST_TX_READY_SIGNAL_ENABLE attribute to false for the deleted OID. The issue is the Oid is already deleted and we receive an error from SAI. - How I verified it Run DPB on the switch
|
Cherry-pick PR to 202405: #3243 |
mssonicbld
pushed a commit
that referenced
this pull request
Jul 25, 2024
…3232) - What I did I added a query before setting host tx ready - must check that Oid exists before setting attribute to SAI. - Why I did it When we do dynamic port breakout to a Fw-control port, portsorch receives a notification that something was deleted in TRANSCEIVER_INFO table from State DB, and tries to set HOST_TX_READY_SIGNAL_ENABLE attribute to false for the deleted OID. The issue is the Oid is already deleted and we receive an error from SAI. - How I verified it Run DPB on the switch
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
yxieca
added
Approved for 202311 Branch
and removed
Cherry Pick Conflict_202311
Approved for 202311 Branch
labels
|
@noaOrMlnx can you help creating separate PR for 202311 branch? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I added a query before setting host tx ready - must check that Oid exists before setting attribute to SAI.
Why I did it
When we do dynamic port breakout to a Fw-control port, portsorch receives a notification that something was deleted in TRANSCEIVER_INFO table from State DB, and tries to set HOST_TX_READY_SIGNAL_ENABLE attribute to false for the deleted OID.
The issue is the Oid is already deleted and we receive an error from SAI.
How I verified it
Run DPB on the switch
Details if related